-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] for Pull Request, Resolve Conflicts via WEB #9014
Comments
https://stackoverflow.com/a/6283843 |
@UBowt571 until now ... yes :/ |
+1 |
Is there someone already working on it ? |
@UBowt571 All contributions are welcome! 😄 |
I'll try to have a go at this other the next |
+1 |
Go on @richmahn, I've lost track of this and won't be able to submit anything anytime soon |
@richmahn Ho, go ahead, I surrendered (normal as a French guy lol) and switched to self-hosted gitlab instead |
@maskym Haha. Loved the French joke. I've been working on Gitea and with Go since 2016, even the one who added the original web interface for editing files, so I should be able to do it. Thanks for the update! |
We are investigating if Geany would be a viable alternative for the huge Gitlab installation we have running now, and the only real blocker we are seeing now is the lack of conflict resolving within the webinterface. This was mentioned in #14477 but lost traction and it never reached the 1.16 milestone. @richmahn do you have any plans on implementing this? I have zero experience in coding for Gitea or Go, so I can't be of any help. |
@MrHaroldA Totally forgot I even mentioned I would work on this. Will put it on my todo list and see if I can take a stab at it in the coming week. |
@richmahn Still wish I had this feature sometimes for productivity sake 😆 By now, I had to learn git more in detail, can you imagine? |
I have a PR that now says 2 files are in conflic with the recieving repo., but i still see now way to resolve this... How in earths name can I now fix this? Local repo says everything is fine. Won't let me delete the PR either. |
@richmahn any news on this? |
@ktpx that's off topic ... but: merge target branch locally or rebase and push |
@eUgEntOptIc44 Sadly haven't had time to work on it, but have mentioned it to my team how badly it is needed. Hopefully can look at it soon, or if someone else wants to get this done, let me know. Should we do it exactly like Github does it, or have some extra functionality to making merging easier? |
@richmahn thank you for your update on this. I'd like to directly support on this by contributing code. Unfortunately my knowledge of go is very limited. However I hope that you or someone else might be able to do so. |
@richmahn @eUgEntOptIc44 I am also interested in contributing to this feature that would be extremely helpful for my team's needs as well. I would also mention that the way Github handles merge conflict would be a great baseline for an initial implementation. Please let me know if available for collaboration on this much needed feature. |
I'm not aware of any draft so I would say go on and it is yours ;) |
@jayczech23 I'm still needing this and keep playing around with getting this implemented like Github. Can we collaborate together? |
@jayczech23 Are you on the Gitea Discord server? If we could touch base there I would be far more likely to get to work on this and better communication since I do everything with Discord. https://discord.gg/mPWThBne |
For simple conflicts, especially for writing documentation or books, this feature is really useful. |
@ richmahn , any news with this issue? Do u need a help |
@NatashaCyn Funny, I just thought about the dire need my organization has for this feature, yet I still haven't gotten to it. I really would like there to be a 2-3 of us working on this...not that I couldn't program it, as I even made the file editor/committer for Gogs/Gitea interface (the original anyway, I'm sure it has been refactored), but to make sure we are doing it right, both how Github does, but also maybe in a way that could improve on that, would be great to have others working on it. |
@NatashaCyn I'm trying to get my company's fork and codebase up-to-date with Gitea 1.19.3 and release it. Once that is done, hopefully I can look more at the conflict resolver. |
Ok, getting my company fork updated from v1.20, lol. Pretty much done. |
Just wanted to add that this feature would be fantastic! If implementation hasn't started yet, I'd like to say I love how clear the IntelliJ/PyCharm style of merge conflict resolution is: The sweet part about this implementation is two-fold:
Unfortunately not a Go coder, but definitely following along in case there's anything minor I can contribute! |
@ijustlovemath Yeah, I agree, that looks great. Wonder how well to do it in a web interface though. |
The main challenge with any sort of conflict resolution UI will always be horizontal space. As long as there's a synchronized horizontal scrollbar and a minimum about of horizontal space (enough room for 90/150/180/240 columns + surrounding UI), it should be workable! This type of interface probably leaves mobile users out to dry, but I wonder how many people are trying to do complex merge conflict resolution on their mobile devices to begin with Another alternative could be to do it in stages, eg "select changes from your version", "select changes from remote version", "final review", which you could do in some kind of tabbed UI, but then you lose the clarity of having the full picture laid out before you. Interested to hear any thoughts from others! |
For the mobile users and quick fixes in general: How about a quick "Accept all incoming changes" and "Accept all local changes" |
I am excited to see this. @yardenshoham thanks for accepting this. |
Just to clarify, I think this is a good idea. I don't plan on implementing it personally. |
@yardenshoham It's all yours! haha. I know that. I don't mind doing it myself. I just need to find time as it is on my comapny's time the work I put into Gitea. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
That was me ^ |
/attempt #9014
|
@oliverqx Want to team up? I've been meaning to get to this and my developers even asked about it recently and told them I would get to it once my big project that ended last quarter (March 31) was over, and now it is over. Interesting to see there is now a bounty on this. |
/attempt #9014 Options |
Not trying to step on any toes here, but seeing what happens if someone else also does an attempt. |
/attempt #9014 |
you can go ahead, I think i'll be busy for the following couple of weeks |
Back to working on this finally. Just made a move across the country the last few months. |
Hope you've settled in well! :- ) Exciting stuff! |
hi everyone :D how can i increase the bounty haha, this feature would be dope to manage our conflicts in our gitea soc/siem/soar project. |
this is part of #5158 summary ... and could be an addition of #9013
The text was updated successfully, but these errors were encountered: