-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Vue to refactor pull merge UI #19650
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@6543 I am cleaning comments, the eslint and script-module cann't work together. pull & try again. |
@wxiaoguang please resolve config |
Need to confirm a change first: https://github.com/go-gitea/gitea/pull/18177/files#r867490307 |
# Conflicts: # templates/repo/issue/view_content/pull.tmpl
I think that the change in pull.tmpl on main branch might be wrong. So I just keep the detailed message textarea for squash merge in this PR. Updated. |
@wxiaoguang Merge conflict resolution? |
This comment was marked as off-topic.
This comment was marked as off-topic.
* giteaofficial/main: Use Vue to refactor pull merge UI (go-gitea#19650) [skip ci] Updated translations via Crowdin
* Use Vue to refactor pull merge UI * add comments * fix comments * small fine tune * fix tests * adopt new pull default messages * clean up Co-authored-by: 6543 <6543@obermui.de>
Regression bug of #19650 Close #20983 Close #21912 ### The "Manually Merged" form ![image](https://user-images.githubusercontent.com/2114189/220170503-32638994-b509-4251-8aa1-d8393dda7184.png) ### Mark a PR as Manually Merged and close it ![image](https://user-images.githubusercontent.com/2114189/220170537-25c91b2c-7a9a-44d1-9e6a-ebe3f1dfc26a.png) --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This PR would help
to get a clear code base.
And this PR use real code to show how to rewrite UI to Vue
At the moment, to keep the UI the same, some Fomantic UI styles are still being used.
I just did some simple tests, it should work as expected. Feel free to report bugs or edit on this PR directly.