-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification: queue ui.go notification-service #10281
Merged
techknowlogick
merged 2 commits into
go-gitea:master
from
zeripath:separate-out-ui-notifier-queue
Feb 16, 2020
Merged
Notification: queue ui.go notification-service #10281
techknowlogick
merged 2 commits into
go-gitea:master
from
zeripath:separate-out-ui-notifier-queue
Feb 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Feb 15, 2020
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 15, 2020
A small nit, otherwise LGTM. |
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 15, 2020
guillep2k
reviewed
Feb 15, 2020
lafriks
approved these changes
Feb 15, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #10281 +/- ##
==========================================
+ Coverage 43.67% 43.72% +0.04%
==========================================
Files 585 585
Lines 81017 81017
==========================================
+ Hits 35387 35421 +34
+ Misses 41250 41215 -35
- Partials 4380 4381 +1
Continue to review full report at Codecov.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @lunny in #9902 this extracts the single commit that moves the ui.go notification-service into a separate queue.