Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification #10331

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix notification #10331

merged 1 commit into from
Feb 18, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 18, 2020

Fix a bug caused by #10281. unexport field will not be mashal to json bytes.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 18, 2020
@lunny lunny added this to the 1.12.0 milestone Feb 18, 2020
zeripath
zeripath approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2020
@zeripath
Copy link
Contributor

Damn I thought I'd fixed that! The change must have gotten missed in all the rebasing

@codecov-io
Copy link

Codecov Report

Merging #10331 into master will increase coverage by <.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10331      +/-   ##
==========================================
+ Coverage   43.69%   43.69%   +<.01%     
==========================================
  Files         585      585              
  Lines       81016    81016              
==========================================
+ Hits        35397    35398       +1     
+ Misses      41230    41229       -1     
  Partials     4389     4389
Impacted Files Coverage Δ
modules/notification/ui/ui.go 70.37% <73.33%> (ø) ⬆️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
modules/queue/workerpool.go 58% <0%> (+1.06%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a43a0...12c77db. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@lafriks lafriks merged commit 21e771c into go-gitea:master Feb 18, 2020
@lunny lunny deleted the lunny/fix_notification branch February 18, 2020 08:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @codecov-io @lafriks @GiteaBot