Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tributejs to npm/webpack #11497

Merged
merged 9 commits into from
May 21, 2020
Merged

Move tributejs to npm/webpack #11497

merged 9 commits into from
May 21, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 18, 2020 •
edited
Loading

  • Move vendored bundle to npm and webpack
  • Rewrote initialization to single function
  • Restyled it (made it a bit smaller)
  • Fixed it for arc-green

image

image

image

@silverwind
Move tributejs to npm/webpack
918f39c 
- Move vendored bundle to npm and webpack
- Rewrote initialization to single function
- Restyled it (made it a bit smaller)
- Fixed it for arc-green
@silverwind
fix mention
f7b3d57
@silverwind
also include emoji on #content
762b552
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2020
@silverwind @mrsdizzie
Update web_src/less/_tribute.less
9c5528d 
Co-authored-by: mrsdizzie <info@mrsdizzie.com>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 19, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 19, 2020
@silverwind
Copy link
Member Author

Note the warnings about tribute being bound twice are still present. I'm not sure yet how to fix but it's no blocker as the warning is present on master too.

@silverwind
Copy link
Member Author

Will have a look later into those warnings, I think the initialization can be combined into one Tribute instance to fix it.

@silverwind
Copy link
Member Author

Double initialization is fixed for the case of a single attachTribute call and the warning should be gone when opening a issue. It's still possible to occur if attachTribute is called twice on the same element, but I don't think we do that currently.

@silverwind
Copy link
Member Author

I wonder why @CirnoT's review did not count.

gary-kim
gary-kim approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit b02d2c3 into go-gitea:master May 21, 2020
@silverwind silverwind mentioned this pull request May 22, 2020
Merged
@silverwind silverwind deleted the tribute-webpack branch May 22, 2020 20:36
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind @mrsdizzie @techknowlogick
Move tributejs to npm/webpack (go-gitea#11497)
55bcd1c 
* Move tributejs to npm/webpack

- Move vendored bundle to npm and webpack
- Rewrote initialization to single function
- Restyled it (made it a bit smaller)
- Fixed it for arc-green

* fix mention

* also include emoji on #content

* Update web_src/less/_tribute.less

Co-authored-by: mrsdizzie <info@mrsdizzie.com>

* rewrite to only use one instance of Tribute

* refactor

* fix copy/paste error

Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie left review comments

@CirnoT CirnoT CirnoT approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @techknowlogick @CirnoT @mrsdizzie @gary-kim @zeripath @GiteaBot