Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enter not working in SimpleMDE #11564

Merged
merged 2 commits into from
May 23, 2020
Merged

Fix Enter not working in SimpleMDE #11564

merged 2 commits into from
May 23, 2020

Conversation

silverwind
Copy link
Member

This condition was wrongly inverted, leading to all enter keys being blocked.

Fixes: #11559

@silverwind
Fix Enter not working in SimpleMDE
d4f8e2a 
This condition was wrongly inverted, leading to all enter keys being
blocked.

Fixes: go-gitea#11559
zeripath
zeripath approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 22, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 22, 2020
@silverwind
Copy link
Member Author

Backport is not required as #11497 did not land on 1.12.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2020
@silverwind
Copy link
Member Author

Small tweak pushed to also correctly handle the case when tribute is absent.

@CirnoT
Copy link
Contributor

CirnoT commented May 22, 2020

The arrow-up keypress is not handled correct, it moves cursor within SimpleMDE box and pressing enter after using it to to navigate emoji list just closes the box without emoji being inserted. arrow-down works fine.

@silverwind
Copy link
Member Author

That does sound like a unrelated issue. I'm not motivated to deal with the CodeMirror/SimpleMDE/Tribute amalgamation, it should be fixed eventually with #10729.

CirnoT
CirnoT approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@CirnoT CirnoT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, it happens on v1.11 too, so unrelated.

@techknowlogick techknowlogick merged commit 1752a97 into go-gitea:master May 23, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
Fix Enter not working in SimpleMDE (go-gitea#11564)
5738f22 
* Fix Enter not working in SimpleMDE

This condition was wrongly inverted, leading to all enter keys being
blocked.

Fixes: go-gitea#11559

* fix it for absent tribute too
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@CirnoT CirnoT CirnoT approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Unable to use ENTER for newline in SimpleMDE
5 participants
@silverwind @CirnoT @techknowlogick @zeripath @GiteaBot