WIP: Move install routes to chi #13558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
lunny
force-pushed
the
lunny/move_install_chi
branch
3 times, most recently
from
0233e99
to
54edc60
Compare
Codecov Report
@@ Coverage Diff @@
## master #13558 +/- ##
==========================================
- Coverage 41.87% 41.79% -0.08%
==========================================
Files 742 745 +3
Lines 79309 79460 +151
==========================================
+ Hits 33209 33212 +3
- Misses 40641 40784 +143
- Partials 5459 5464 +5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/move_install_chi
branch
from
08bf3bf
to
ff4c4a0
Compare
lunny
force-pushed
the
lunny/move_install_chi
branch
from
e4b6a87
to
6d5fd8b
Compare
|
Blocked by #13857 |
lunny
force-pushed
the
lunny/move_install_chi
branch
3 times, most recently
from
85d8f25
to
b583b87
Compare
lunny
force-pushed
the
lunny/move_install_chi
branch
from
9dcd9f3
to
dadff13
Compare
6543
reviewed
Jan 5, 2021
6543
reviewed
Jan 5, 2021
modules/options/static.go
Outdated
| @@ -133,7 +133,7 @@ func AssetNames() []string { | |||
| realFS := Assets.(vfsgen۰FS) | |||
| var results = make([]string, 0, len(realFS)) | |||
There was a problem hiding this comment.
func AssetNames() []string {} has no desciption -> lint issue
lunny
force-pushed
the
lunny/move_install_chi
branch
from
4e8c771
to
2495059
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced by #14293