-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recovery middleware to render gitea style page. #13857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9cc999
to
6c60d40
Compare
This was referenced Dec 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #13857 +/- ##
==========================================
- Coverage 41.97% 41.87% -0.10%
==========================================
Files 735 742 +7
Lines 78933 79309 +376
==========================================
+ Hits 33132 33211 +79
- Misses 40346 40635 +289
- Partials 5455 5463 +8
Continue to review full report at Codecov.
|
c7a09e3
to
d28e7dd
Compare
6543
reviewed
Dec 21, 2020
6543
reviewed
Dec 21, 2020
6543
reviewed
Dec 21, 2020
7d42691
to
bc8fbde
Compare
@6543 All done. |
6543
approved these changes
Dec 21, 2020
ec5a9f6
to
df74647
Compare
6543
approved these changes
Dec 21, 2020
@techknowlogick Could you review this again? |
df74647
to
f1daa29
Compare
39d4ce3
to
c178867
Compare
lafriks
approved these changes
Jan 5, 2021
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to recovery middleware will always output trace log content to web browser when panic. It's a regression.
This PR introduced some new middlewares to chi and will fix that and take them back.