Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug because of duplicated join #14454

Merged
merged 7 commits into from
Jan 26, 2021
Merged

Fix bug because of duplicated join #14454

merged 7 commits into from
Jan 26, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2021

Fix #14448

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 25, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2021
@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 25, 2021
jpraet
jpraet reviewed Jan 25, 2021
View reviewed changes
models/issue.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 26, 2021 •
edited
Loading

Codecov Report

Merging #14454 (02e502d) into master (a598877) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14454   +/-   ##
=======================================
  Coverage   42.12%   42.13%           
=======================================
  Files         758      758           
  Lines       81080    81083    +3     
=======================================
+ Hits        34155    34164    +9     
+ Misses      41352    41348    -4     
+ Partials     5573     5571    -2
Impacted Files Coverage Δ
models/issue.go 57.24% <100.00%> (+0.10%) ⬆️
modules/git/tree_nogogit.go 60.86% <0.00%> (-8.70%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-4.26%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.52% <0.00%> (-2.21%) ⬇️
routers/repo/view.go 40.95% <0.00%> (-0.63%) ⬇️
models/error.go 39.48% <0.00%> (-0.49%) ⬇️
modules/indexer/stats/db.go 68.00% <0.00%> (ø)
services/pull/pull.go 42.64% <0.00%> (+0.49%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a598877...02e502d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2021
@6543 6543 merged commit d3aa497 into go-gitea:master Jan 26, 2021
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
8f5873d 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
  [skip ci] Updated translations via Crowdin
  Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
@lunny lunny deleted the lunny/fix_your_repository branch January 27, 2021 01:49
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into ui_create_tag
8252fa5 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
  [skip ci] Updated translations via Crowdin
  Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into empty_pr
14f7d33 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpraet jpraet jpraet left review comments

@techknowlogick techknowlogick techknowlogick left review comments

@6543 6543 6543 approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

[Bug] 500 error when searching issues with type=your_repository
7 participants
@lunny @codecov-io @techknowlogick @lafriks @jpraet @6543 @GiteaBot