Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic 500 page rendering #14474

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fix panic 500 page rendering #14474

merged 1 commit into from
Jan 26, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 26, 2021

Fix #14473

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 26, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 26, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2021
@6543 6543 merged commit 0f726ca into go-gitea:master Jan 26, 2021
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
8f5873d 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
  [skip ci] Updated translations via Crowdin
  Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
@lunny lunny deleted the lunny/fix_recovery branch January 27, 2021 01:49
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into ui_create_tag
8252fa5 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
  [skip ci] Updated translations via Crowdin
  Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 27, 2021
@a1012112796
Merge branch 'master' into empty_pr
14f7d33 
* master:
  [skip ci] Updated translations via Crowdin
  Fix bug because of duplicated join (go-gitea#14454)
  Cron job to cleanup hook_task table (go-gitea#13080)
  Fix panic 500 page rendering (go-gitea#14474)
  [skip ci] Updated translations via Crowdin
  Move macaron to chi (go-gitea#14293)
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

500 page not rendered
4 participants
@lunny @6543 @a1012112796 @GiteaBot