Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new golangci-linters #17610

Merged
merged 7 commits into from
Nov 17, 2021
Merged

Enable new golangci-linters #17610

merged 7 commits into from
Nov 17, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 10, 2021

@Gusted Gusted mentioned this pull request Nov 10, 2021
Closed
8 tasks
@Gusted Gusted marked this pull request as ready for review November 10, 2021 19:19
@Gusted Gusted changed the title Wip: enable new golangci-linters Enable new golangci-linters Nov 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 10, 2021
@wxiaoguang
Copy link
Contributor

CI failure is related

@wxiaoguang wxiaoguang mentioned this pull request Nov 11, 2021
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 11, 2021
@Gusted
Copy link
Contributor Author

Gusted commented Nov 11, 2021

CI failure is related

That's expected, as the new linter was added in the latest version of golangci-lint, which cannot be upgraded before the new linting errors are fixed.

@Gusted
Copy link
Contributor Author

Gusted commented Nov 15, 2021

Blocked by #17647

@lunny
Copy link
Member

lunny commented Nov 17, 2021

make L-G-T-M work.

@lunny lunny merged commit adda276 into go-gitea:main Nov 17, 2021
@Gusted Gusted deleted the new-linter branch November 24, 2021 08:26
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @6543
Enable bidichk (go-gitea#17610)
8eceb8f 
- https://github.com/breml/bidichk

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @wxiaoguang @lunny @techknowlogick @GiteaBot @6543