Update golangci-lint in Makefile

[Gusted]

• Partially resolvess Tracking issue: Updating golangci-lint #17596
• Download specific version(v1.43.0) by default.
• If current installed version is older than the minium version, it will download the mininium required version.
• Update the install script to avoid deprecated error golangci/golangci-lint err this script is deprecated, please do not use it anymore. check https://github.com/goreleaser/godownloader/issues/207

[silverwind]

I think we should do away with globally installed modules as different projects can require different versions of the linter, resulting in conflicts. Does golang offer a solution to install such devDependencies locally yet (Without fake imports)?

[Gusted]

Does golang offer a solution to install such devDependencies locally yet (Without fake imports)?

Does golang offer such solution officially? No, it doesn't.
Does golang support such solution possibly? Yeah-ish, see golang/go#25922 (comment) it's the best thing you can get, but it feels like a hack for me.

[silverwind]

Yeah, such fake imports are unacceptable I think because it will download/build these dependencies even on regular builds.

[Gusted]

Yeah, such fake imports are unacceptable I think because it will download/build these dependencies even on regular builds.

Not if you have a custom XXX.mod file like mentioned, it will only download the go.mod's dependencies by default.

[silverwind]

For the version check, why not do it like it's done for go/node? It's much simpler and should suffice:

gitea/Makefile

Lines 200 to 205 in ab13797

	go-check:
	$(eval GO_VERSION := $(shell printf "%03d%03d%03d" $(shell $(GO) version | grep -Eo '[0-9]+\.[0-9.]+' | tr '.' ' ');))
	@if [ "$(GO_VERSION)" -lt "$(MIN_GO_VERSION)" ]; then \
	echo "Gitea requires Go 1.16 or greater to build. You can get it at https://golang.org/dl/"; \
	exit 1; \
	fi

[Gusted]

For the version check, why not do it like it's done for go/node? It's much simpler and should suffice:

gitea/Makefile

Lines 200 to 205 in ab13797

	go-check:
	$(eval GO_VERSION := $(shell printf "%03d%03d%03d" $(shell $(GO) version | grep -Eo '[0-9]+\.[0-9.]+' | tr '.' ' ');))
	@if [ "$(GO_VERSION)" -lt "$(MIN_GO_VERSION)" ]; then \
	echo "Gitea requires Go 1.16 or greater to build. You can get it at https://golang.org/dl/"; \
	exit 1; \
	fi

Not sure how I missed that part, the version check is now simplified, thanks.

[Gusted]

Yeah, such fake imports are unacceptable I think because it will download/build these dependencies even on regular builds.

Not if you have a custom XXX.mod file like mentioned, it will only download the go.mod's dependencies by default.

NVM that, it still requires to have a file with fake imports.

[techknowlogick]

This will also need to be updated in the following repo: https://gitea.com/gitea/test-env/

[silverwind]

Download does not work, it tries on non-existing URL https://raw.githubusercontent.com/golangci/golangci-lint/001043000.

[Gusted]

This will also need to be updated in the following repo: https://gitea.com/gitea/test-env/

https://gitea.com/gitea/test-env/pulls/10

[lunny]

https://gitea.com/gitea/test-env/pulls/10

merged.

[zeripath]

Otherwise LGTM

[silverwind]

It bothers me a bit that the checks work differently the go/node which are defined with zero-padded numbers. Maybe make those checks match by either formatting/de-formatting their versions consistently?

[Gusted]

Voila - done.

[codecov-commenter]

Codecov Report

Merging #17647 (ba6eee6) into main (8fdc524) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #17647      +/-   ##
==========================================
- Coverage   45.35%   45.34%   -0.02%     
==========================================
  Files         799      799              
  Lines       89062    89062              
==========================================
- Hits        40393    40382      -11     
- Misses      42163    42174      +11     
  Partials     6506     6506              

Impacted Files	Coverage Δ
models/gpg_key_common.go	59.67% <0.00%> (-4.84%)	⬇️
modules/queue/workerpool.go	48.47% <0.00%> (-3.44%)	⬇️
modules/queue/queue_disk_channel.go	60.94% <0.00%> (-1.78%)	⬇️
services/pull/pull.go	42.19% <0.00%> (+0.40%)	⬆️
modules/log/file.go	75.20% <0.00%> (+1.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42670e6...ba6eee6. Read the comment docs.