Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable federation by default #20045

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Disable federation by default #20045

merged 2 commits into from
Jun 19, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 19, 2022

  • A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software.

Disable federation by default
b1b3d18 
- A Gitea instance should choose whetever they want to federate(as once
it has more features also brings extra costs/moderation/unexpected
behavior) with other AP/ForgeFed software.
@Gusted Gusted added this to the 1.18.0 milestone Jun 19, 2022
delvh
delvh approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it doesn't even really exist in 1.17 it isn't even breaking :)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 19, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Jun 19, 2022

Given that it doesn't even really exist in 1.17 it isn't even breaking :)

Ah thanks for reminding, this does need backporting.

@delvh
Copy link
Member

delvh commented Jun 19, 2022

That wasn't even what I intended to say, but yeah, you're right, it can also be backported...

Gusted pushed a commit to Gusted/gitea that referenced this pull request Jun 19, 2022
Disable federation by default (go-gitea#20045)
641f796 
- Backport go-gitea#20045
  - A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software.
@Gusted Gusted mentioned this pull request Jun 19, 2022
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Jun 19, 2022

Backport: #20046

@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 19, 2022
@lunny
Copy link
Member

lunny commented Jun 19, 2022

LGTM

@lunny lunny merged commit 02d7458 into go-gitea:main Jun 19, 2022
@Gusted Gusted deleted the disable-federation-by-default branch June 20, 2022 00:00
lunny pushed a commit that referenced this pull request Jun 20, 2022
Disable federation by default (#20045) (#20046)
761db4d 
* Disable federation by default (#20045)

- Backport #20045
  - A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software.

* Fix tests
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
201d49d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Catch the error before the response is processed by goth. (go-gitea#20000)
  Adjust transaction handling via db.Context (go-gitea#20031)
  Add more linters to improve code readability (go-gitea#19989)
  [skip ci] Updated translations via Crowdin
  Disable federation by default (go-gitea#20045)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20026)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038)
  Simplify and fix migration 216 (go-gitea#20035)
  use quoted regexp instead of git fixed-value (go-gitea#20029)
  fix delete pull head ref for DeleteIssue (go-gitea#20032)
  User keypairs and HTTP signatures for ActivityPub federation using go-ap (go-gitea#19133)
  Backtick table name in generic orphan check (go-gitea#20019)
  Update document to clarify that ALLOWED_DOMAINS/BLOCKED_DOMAINS support wildcard (go-gitea#20016)
  Return 404 when tag is broken (go-gitea#20017)
  Dump should only copy regular files and symlink regular files (go-gitea#20015)
@6543 6543 added the backport/done All backports for this PR have been created label Jun 23, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Disable federation by default (go-gitea#20045)
1243d1d
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Disable federation by default (go-gitea#20045)
249b86d
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/federation
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @delvh @lunny @jolheiser @GiteaBot @6543