Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable federation by default (#20045) #20046

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Disable federation by default (#20045) #20046

merged 3 commits into from
Jun 20, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 19, 2022

  • Backport Disable federation by default #20045
    • A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software.

Disable federation by default (go-gitea#20045)
641f796 
- Backport go-gitea#20045
  - A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software.
@Gusted Gusted added this to the 1.17.0 milestone Jun 19, 2022
@Gusted Gusted added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/federation and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 19, 2022
@Gusted Gusted mentioned this pull request Jun 19, 2022
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2022
@delvh
Copy link
Member

delvh commented Jun 19, 2022

I think it can have skip-changelog since it didn't exist before 1.17...

@Gusted
Copy link
Contributor Author

Gusted commented Jun 19, 2022

I think it can have skip-changelog since it didn't exist before 1.17...

Yeah but should 1.18 also have the skip-changelog, as it wasn't introduced in that release either/

@delvh
Copy link
Member

delvh commented Jun 19, 2022

Both?

@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 19, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Jun 19, 2022

Both?

Yeah seems to make sense, never thought about it, but definitely had these situations before. So seems like some changelogs might be not accurate 🙈.

@lunny
Copy link
Member

lunny commented Jun 20, 2022

LGTM

@lunny lunny merged commit 761db4d into go-gitea:release/v1.17 Jun 20, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@jolheiser jolheiser jolheiser approved these changes

@42wim 42wim 42wim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/federation
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @delvh @lunny @42wim @jolheiser @GiteaBot