Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: implement mirroring for issues and pull requests #20122

Closed
wants to merge 4 commits into from

Conversation

silentcodeg
Copy link
Contributor

No description provided.

@silentcodeg silentcodeg self-assigned this Jun 24, 2022
@silentcodeg silentcodeg added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Jun 24, 2022
@silentcodeg silentcodeg added this to the 1.18.0 milestone Jun 24, 2022
@techknowlogick techknowlogick marked this pull request as draft June 24, 2022 17:40
@harryzcy
Copy link
Contributor

I just noticed this pull request is the same as my work at #20311. Only one PR between this one and #20311 will be merged eventually.

How are you planning to going forward with this? I don't want the duplicated work going in parallel, so I think it's better to discuss now and sort out the approach.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 16, 2022
@silentcodeg
Copy link
Contributor Author

How are you planning to going forward with this?

Yes.

This is a difficult problem to solve. It is easy to hack and test manually but there will be recurring undetected regressions so frequently that it will not be widely usable (check the latest commits related to dump-repo/restore-repo for instance) and very difficult to maintain. The challenge is to build a sound codebase that is thoroughly tested and properly architectured.

I believe the Friendly Forge Format (F3) is a good way to approach this, reason why I'm motivated to make it work for Gitea. F3 is a new project but is actively developed.

If you'd like to discuss it further, there is a forum and a chatroom.

@silentcodeg silentcodeg force-pushed the feature-fff branch 2 times, most recently from 10192b4 to 3044436 Compare July 17, 2022 08:08
@harryzcy
Copy link
Contributor

Given that 'F3 Go' uses AGPL license, it can't be imported by Gitea directly right? Gitea can only use the file format specification and implement them internally.

@Gusted
Copy link
Contributor

Gusted commented Jul 23, 2022

Per usual, I'm not a lawyer.

Given that 'F3 Go' uses AGPL license, it can't be imported by Gitea directly right?

Well, slight correction it can be imported by Gitea. But according to the GPL terms(given this is derivative work on AGPL as otherwise the program won't function), Gitea must (and only can be) licensed under AGPL license, which isn't the case.

Currently(according to go-license) Gitea only imports MIT, Apache-2.0, BSD-3-Clause, BSD-2-Clause, MPL-2.0, ISC. So I was initially going to say "Oh Gitea likely already uses a GPL-alike license, so it should be fine", however this isn't the case and doing some searches does explicitly imply that there is no exception to be able to use the library and not distribute Gitea under GPL. So it seems to be that Gitea cannot use the F3 Go library.

@Gusted
Copy link
Contributor

Gusted commented Jul 23, 2022

I've asked Loïc Dachary, the main contributor of F3 Go in the Forge Federation general matrix room about the license. I quote:

I will change the license to be compatible with the Gitea license
when and if the pull request is accepted. That won't be a blocker.

So it's fine to use the F3 Go library.

Loïc Dachary added 4 commits July 23, 2022 10:19
GOPROXY=direct go get lab.forgefriends.org/friendlyforgeformat/gofff

and strip the remaining lines from go.sum
@silentcodeg
Copy link
Contributor Author

@harryzcy a short note to let you know I'm still motivated to move forward with this pull request. I'm following the progress of the F3 and will update the PR once it is more stable than it currently is. There is daily work done here and it looks promising.

@earl-warren
Copy link
Contributor

Unless there is an objection I'm willing to work on landing this pull request. With a different approach which is more likely to be accepted, by proposing an optional new feature instead of a large replacement of the existing codebase.

@silentcodeg
Copy link
Contributor Author

@earl-warren there is no easy way to hand over this pull request so I'll just close it so another one can be opened. That makes sense.

@silentcodeg silentcodeg closed this Sep 6, 2022
@lunny lunny removed this from the 1.18.0 milestone Dec 20, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants