-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: implement mirroring for issues and pull requests #20122
Conversation
Yes. This is a difficult problem to solve. It is easy to hack and test manually but there will be recurring undetected regressions so frequently that it will not be widely usable (check the latest commits related to dump-repo/restore-repo for instance) and very difficult to maintain. The challenge is to build a sound codebase that is thoroughly tested and properly architectured. I believe the Friendly Forge Format (F3) is a good way to approach this, reason why I'm motivated to make it work for Gitea. F3 is a new project but is actively developed. If you'd like to discuss it further, there is a forum and a chatroom. |
10192b4
to
3044436
Compare
Given that 'F3 Go' uses AGPL license, it can't be imported by Gitea directly right? Gitea can only use the file format specification and implement them internally. |
Per usual, I'm not a lawyer.
Well, slight correction it can be imported by Gitea. But according to the GPL terms(given this is derivative work on AGPL as otherwise the program won't function), Gitea must (and only can be) licensed under AGPL license, which isn't the case. Currently(according to go-license) Gitea only imports MIT, Apache-2.0, BSD-3-Clause, BSD-2-Clause, MPL-2.0, ISC. So I was initially going to say "Oh Gitea likely already uses a GPL-alike license, so it should be fine", however this isn't the case and doing some searches does explicitly imply that there is no exception to be able to use the library and not distribute Gitea under GPL. So it seems to be that Gitea cannot use the F3 Go library. |
I've asked Loïc Dachary, the main contributor of F3 Go in the Forge Federation general matrix room about the license. I quote:
So it's fine to use the F3 Go library. |
GOPROXY=direct go get lab.forgefriends.org/friendlyforgeformat/gofff and strip the remaining lines from go.sum
Unless there is an objection I'm willing to work on landing this pull request. With a different approach which is more likely to be accepted, by proposing an optional new feature instead of a large replacement of the existing codebase. |
@earl-warren there is no easy way to hand over this pull request so I'll just close it so another one can be opened. That makes sense. |
No description provided.