Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Friendly Forge Format (F3) #21081

Closed
wants to merge 1 commit into from
Closed

Add support for the Friendly Forge Format (F3) #21081

wants to merge 1 commit into from

Conversation

earl-warren
Copy link
Contributor

@earl-warren earl-warren commented Sep 6, 2022 •
edited by 6543
Loading

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

depends on:

Continuation of this previous pull request

@earl-warren earl-warren marked this pull request as draft September 6, 2022 05:03
@earl-warren earl-warren mentioned this pull request Sep 6, 2022
Closed
@earl-warren earl-warren changed the title F3: initial support with user & project providers Add support for the Friendly Forge Format (F3) Sep 6, 2022
@silentcodeg silentcodeg added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Sep 6, 2022
@earl-warren
Copy link
Contributor Author

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2022
@silverwind
Copy link
Member

silverwind commented Sep 6, 2022 •
edited
Loading

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

I think the only logical reason would be presence of //go:build tags that run only on Windows, but that doesn't seem to be the case here. Might just restart and see if it goes away.

@earl-warren
Copy link
Contributor Author

earl-warren commented Sep 7, 2022 •
edited
Loading

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

I think the only logical reason would be presence of //go:build tags that run only on Windows, but that doesn't seem to be the case here. Might just restart and see if it goes away.

But there are no //go:build tags in this PR. Is there a way to re-launch the CI and verify this is not a false negative?

@silverwind
Copy link
Member

Just push an empty commit to restart CI:

git commit --allow-empty -m 'restart ci'

@earl-warren

This comment was marked as resolved.

Sign in to view
@earl-warren earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from be0af5f to 17e66df Compare September 8, 2022 07:19
6543
6543 reviewed Sep 8, 2022
View reviewed changes
services/f3/driver/driver.go Outdated Show resolved Hide resolved
@earl-warren earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from f8cd0a9 to e4ce565 Compare September 9, 2022 00:43
@earl-warren

This comment was marked as resolved.

Sign in to view
@delvh
Copy link
Member

delvh commented Sep 9, 2022

We know. #21108

@earl-warren

This comment was marked as resolved.

Sign in to view
@earl-warren earl-warren force-pushed the gitea-feature-f3 branch 7 times, most recently from ae00aee to c4a5a4d Compare September 16, 2022 15:22
@earl-warren earl-warren marked this pull request as draft September 21, 2022 15:23
@silverwind
Copy link
Member

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

@earl-warren
Copy link
Contributor Author

earl-warren commented Sep 23, 2022 •
edited
Loading

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

I did not want to force people to agree to the GitHub terms of service to participate in this particular pull request. Moving the discussion to gitea.com is more inclusive in a way that is not disruptive to the Gitea development process.

@earl-warren earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from 0020f29 to e764d44 Compare September 24, 2022 07:24
@earl-warren
Copy link
Contributor Author

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

I did not want to force people to agree to the GitHub terms of service to participate in this particular pull request. Moving the discussion to gitea.com is more inclusive in a way that is not disruptive to the Gitea development process.

I commented further on the issue you opened that is related to this topic.

@earl-warren earl-warren marked this pull request as ready for review September 24, 2022 11:49
@Gusted
Copy link
Contributor

Gusted commented Sep 24, 2022

Just to mention this again, a valid point was raised on the previous PR for F3. I would like to state again that Loïc and the other contributors will change the license to MIT when this PR is approved to be merged.

@earl-warren earl-warren force-pushed the gitea-feature-f3 branch 6 times, most recently from 7c09cb6 to 251a962 Compare October 2, 2022 15:58
@earl-warren
F3: Gitea driver and CLI
61302eb 
user, topic, project, label, milestone, repository, pull_request,
release, asset, comment, reaction, review providers

Signed-off-by: Earl Warren <contact@earl-warren.org>
@6543
Copy link
Member

6543 commented Oct 16, 2022 •
edited
Loading

@earl-warren could you add me to your fork as contrib (write access)? so i can update that pull ... also if you would not force-push I would aprechiate!

@6543 6543 added this to the 1.18.0 milestone Oct 16, 2022
@6543
Copy link
Member

6543 commented Oct 16, 2022

blocked by https://lab.forgefriends.org/friendlyforgeformat/gof3/-/issues/21

6543
6543 reviewed Oct 16, 2022
View reviewed changes
modules/setting/f3.go
)

func newF3Service() {
if err := Cfg.Section("F3").MapTo(&F3); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other sections are lowercase

Suggested change
if err := Cfg.Section("F3").MapTo(&F3); err != nil {
if err := Cfg.Section("f3").MapTo(&F3); err != nil {

6543
6543 reviewed Oct 16, 2022
View reviewed changes
custom/conf/app.example.ini
@@ -2294,6 +2294,15 @@ ROUTER = console
;; If a domain is allowed by ALLOWED_DOMAINS, this option will be ignored.
;ALLOW_LOCALNETWORKS = false

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;[F3]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
;[F3]
;[f3]

@6543
Copy link
Member

6543 commented Oct 24, 2022

please update branch & update f3 dep

@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 26, 2022
@lunny lunny removed this from the 1.19.0 milestone Feb 22, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@6543 6543 6543 left review comments

Assignees

@earl-warren earl-warren

Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@earl-warren @silverwind @delvh @Gusted @6543 @lunny @GiteaBot @silentcodeg