Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slight bug in katex #21171

Merged
merged 7 commits into from
Oct 5, 2022
Merged

Fix slight bug in katex #21171

merged 7 commits into from
Oct 5, 2022

Conversation

zeripath
Copy link
Contributor

There is a small bug in #20571 whereby $a a$b b$ will not be correctly detected as a math inline block of a a$b b. This PR fixes this.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 14, 2022
@zeripath zeripath added this to the 1.18.0 milestone Sep 14, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 14, 2022
@lunny
Copy link
Member

lunny commented Sep 15, 2022

There is a small bug in #20571 whereby $a a$b b$ will not be correctly detected as a math inline block of a a$b b. This PR fixes this.

Signed-off-by: Andrew Thornton art27@cantab.net

Maybe a new test is better.

@zeripath
Fix slight bug in katex
840d938 
There is a small bug in go-gitea#20571 whereby `$a a$b b$` will not be correctly
detected as a math inline block of `a a$b b`. This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
re-enable testcases
50d572b 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath force-pushed the small-additional-fix-to-katex branch from 36c5a67 to 50d572b Compare October 4, 2022 20:31
@zeripath
fix issue with renderconfig
4885ae3 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

zeripath commented Oct 4, 2022

OK tests added.

@wxiaoguang wxiaoguang mentioned this pull request Oct 5, 2022
Closed
@wxiaoguang
Copy link
Contributor

I closed #21340, could the fixes be taken in this one?

  • Add missing os.Exit(m.Run()) to markup/html_test.go and fix the test in TestRender_emoji
  • Fix a overflow bug in markup/markdown/meta.go
  • Fix the string vs bytes comparison in markup/markdown/meta_test.go
  • Remove unnecessary util.Dedent, YAML can accept global indention.
  • The comment Trigger returns nil is not touched, not sure what should be written there.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2022
delvh
delvh approved these changes Oct 5, 2022
View reviewed changes
modules/markup/markdown/renderconfig.go Outdated Show resolved Hide resolved
@zeripath @delvh
Update modules/markup/markdown/renderconfig.go
a97d736 
Co-authored-by: delvh <dev.lh@web.de>
@zeripath
Copy link
Contributor Author

zeripath commented Oct 5, 2022

make lgtm work

@zeripath zeripath merged commit 93df41f into go-gitea:main Oct 5, 2022
@zeripath zeripath deleted the small-additional-fix-to-katex branch October 5, 2022 18:55
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @lunny @wxiaoguang @silverwind @delvh @GiteaBot