Skip to content

Fix missing m.Run() in TestMain #21340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix missing m.Run() in TestMain #21340

wants to merge 2 commits into from

Conversation

wxiaoguang
Copy link
Contributor

The necessary m.Run() was forgotten to be added to TestMain, this PR adds the missing m.Run()

@wxiaoguang wxiaoguang added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.17 labels Oct 5, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 5, 2022
@wxiaoguang wxiaoguang mentioned this pull request Oct 5, 2022
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Oct 5, 2022
@wxiaoguang
Copy link
Contributor Author

The full fix is in #21171, only backport is needed.

@wxiaoguang wxiaoguang closed this Oct 5, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2022
@wxiaoguang wxiaoguang deleted the fix-test branch October 5, 2022 02:00
@techknowlogick techknowlogick removed this from the 1.18.0 milestone Oct 5, 2022
@wxiaoguang wxiaoguang mentioned this pull request Oct 5, 2022
Merged
lunny pushed a commit that referenced this pull request Oct 5, 2022
@wxiaoguang
Fix missing m.Run() in TestMain (#21341)
1a9ba1c 
Backport #21340, add the missing m.Run()
zeripath added a commit that referenced this pull request Oct 5, 2022
@zeripath @wxiaoguang
Fix slight bug in katex (#21171)
93df41f 
There is a small bug in #20571 whereby `$a a$b b$` will not be correctly
detected as a math inline block of `a a$b b`. This PR fixes this.

Also reenable test cases as per #21340 

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
@tyroneyeh
Fix missing m.Run() in TestMain (go-gitea#21341)
5690058 
Backport go-gitea#21340, add the missing m.Run()
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxiaoguang @techknowlogick @GiteaBot