feat(pr review): add more space on mobile #21326
Conversation
techknowlogick
added
type/enhancement
web_src/less/_repository.less
Outdated
| @@ -1165,6 +1171,10 @@ | |||
| box-shadow: none; | |||
| } | |||
| } | |||
|
|
|||
| @media @mediaSm { | |||
| padding: 1rem 0 !important; | |||
There was a problem hiding this comment.
Why important?
Because other (fomantic?) style classes interfere otherwise?
There was a problem hiding this comment.
I'd still like a comment here.
As someone (I don't know anymore who) said, it's probably a good idea to force comments explaining !importants, simply so that at some point it can be easily determined if they are still needed.
GiteaBot
added
the
lgtm/need 2
|
What happens if the "commented 23 minutes ago" becomes a longer text? especially in other languages. If there is no general solution for the layout, the margin and padding game don't look like a good solution IMO ...... |
|
@wxiaoguang but that's nothing I changed explicitly in this pr? I think this is a problem worth tackling but more generally outside of the scope of this pr. |
|
Hmm ... at first glance, the only difference I can see is the "commented 23 minutes ago" changed its position ....... |
|
That happened, but it wasn't the primary goal of this PR. Check the width and alignment of the comments and events. |
GiteaBot
added
lgtm/need 1
web_src/less/_repository.less
Outdated
| @@ -1165,6 +1171,10 @@ | |||
| box-shadow: none; | |||
| } | |||
| } | |||
|
|
|||
| @media @mediaSm { | |||
| padding: 1rem 0 !important; | |||
There was a problem hiding this comment.
I'd still like a comment here.
As someone (I don't know anymore who) said, it's probably a good idea to force comments explaining !importants, simply so that at some point it can be easily determined if they are still needed.
GiteaBot
added
lgtm/done
* upstream/main: (25 commits) [skip ci] Updated translations via Crowdin Respect user's locale when rendering the date range in the repo activity page (go-gitea#21410) Consolidate more CSS colors into variables (go-gitea#21402) Add HEAD fix to gitea doctor (go-gitea#21352) Contribution guidelines (go-gitea#21425) Refactor Gitpod configuration to improve quick spin up of automated dev environments (go-gitea#21411) Support instance-wide OAuth2 applications (go-gitea#21335) Case-insensitive NuGet symbol file GUID (go-gitea#21409) Add generic set type (go-gitea#21408) Improve OAuth integration tests (go-gitea#21390) Make e-mail sanity check more precise (go-gitea#20991) Fix broken link to frontend guidelines in hacking guidelines (go-gitea#21382) Use Name instead of DisplayName in LFS Lock (go-gitea#21415) [skip ci] Updated translations via Crowdin feat(pr review): add more space on mobile (go-gitea#21326) Bump `golang.org/x/text` (go-gitea#21412) Update gitea.service (go-gitea#21399) Do DB update after merge in hammer context (go-gitea#21401) add gitpod config (go-gitea#20995) Remove cancel button in repo creation page (go-gitea#21381) ...
This PR adds more space to the review screen on mobile so that comments are more readable and less "squashed" an smaller screens.
Before:
After: