Do DB update after merge in hammer context #21401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merge was changed to run in the background context, the db updates were still running in request context. This means that the merge could be successful but the db not be updated. This PR changes both these to run in the hammer context, this is not complete rollback protection but it's much better. Fix go-gitea#21332 Signed-off-by: Andrew Thornton <art27@cantab.net>
KN4CK3R
approved these changes
Oct 11, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Oct 11, 2022
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 11, 2022
Backport go-gitea#21401 When merge was changed to run in the background context, the db updates were still running in request context. This means that the merge could be successful but the db not be updated. This PR changes both these to run in the hammer context, this is not complete rollback protection but it's much better. Fix go-gitea#21332 Signed-off-by: Andrew Thornton <art27@cantab.net>
wxiaoguang
pushed a commit
that referenced
this pull request
Oct 12, 2022
Backport #21401 When merge was changed to run in the background context, the db updates were still running in request context. This means that the merge could be successful but the db not be updated. This PR changes both these to run in the hammer context, this is not complete rollback protection but it's much better. Fix #21332 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 13, 2022
* upstream/main: (25 commits) [skip ci] Updated translations via Crowdin Respect user's locale when rendering the date range in the repo activity page (go-gitea#21410) Consolidate more CSS colors into variables (go-gitea#21402) Add HEAD fix to gitea doctor (go-gitea#21352) Contribution guidelines (go-gitea#21425) Refactor Gitpod configuration to improve quick spin up of automated dev environments (go-gitea#21411) Support instance-wide OAuth2 applications (go-gitea#21335) Case-insensitive NuGet symbol file GUID (go-gitea#21409) Add generic set type (go-gitea#21408) Improve OAuth integration tests (go-gitea#21390) Make e-mail sanity check more precise (go-gitea#20991) Fix broken link to frontend guidelines in hacking guidelines (go-gitea#21382) Use Name instead of DisplayName in LFS Lock (go-gitea#21415) [skip ci] Updated translations via Crowdin feat(pr review): add more space on mobile (go-gitea#21326) Bump `golang.org/x/text` (go-gitea#21412) Update gitea.service (go-gitea#21399) Do DB update after merge in hammer context (go-gitea#21401) add gitpod config (go-gitea#20995) Remove cancel button in repo creation page (go-gitea#21381) ...
tyroneyeh
pushed a commit
to tyroneyeh/gitea
that referenced
this pull request
Oct 24, 2022
…#21416) Backport go-gitea#21401 When merge was changed to run in the background context, the db updates were still running in request context. This means that the merge could be successful but the db not be updated. This PR changes both these to run in the hammer context, this is not complete rollback protection but it's much better. Fix go-gitea#21332 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merge was changed to run in the background context, the db updates were still running in request context. This means that the merge could be successful but the db not be updated.
This PR changes both these to run in the hammer context, this is not complete rollback protection but it's much better.
Fix #21332
Signed-off-by: Andrew Thornton art27@cantab.net