-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not send notifications for draft releases #21451
Conversation
Hmm... Doesn't this mean that we won't ever get a CreateRelease for a release that is marked as Draft but then is not marked as Draft? |
Draft --> Non-draft (notification issued) |
You won't get the create release... |
No? Because the release has been updated... Do you want to have an create release event when draft --> non-draft? |
Codecov Report
@@ Coverage Diff @@
## main #21451 +/- ##
=========================================
+ Coverage 0 47.61% +47.61%
=========================================
Files 0 1023 +1023
Lines 0 139349 +139349
=========================================
+ Hits 0 66347 +66347
- Misses 0 64996 +64996
- Partials 0 8006 +8006
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Imho this behavior is broken, while I understand the logic, if you are wanting only create events you will never get them if draft is created and then updated to normal release. Even if I get the update event I can't know it was previously draft... If we do not want release to send events for draft we should send create event for when status is changed from draft to normal and delete when from normal to draft imho |
Also imho this is breaking change now and I do not think it should be backported |
Good points from @lafriks , perhaps we should revert this as we are about to create an RC so we can discuss it more |
* upstream/main: (32 commits) inline gitpod image (go-gitea#21494) [skip ci] Updated translations via Crowdin Do not send notifications for draft releases (go-gitea#21451) Update reverse-proxies.zh-cn.md (go-gitea#21484) Docs: Update the feature comparison to other Git Hosting Services (go-gitea#20933) Add some api integration tests (go-gitea#18872) probe if sha before exec git (go-gitea#21467) Fix incorrect notification commit url (go-gitea#21479) Localize all timestamps (go-gitea#21440) [skip ci] Updated translations via Crowdin Add system setting table with cache and also add cache supports for user setting (go-gitea#18058) Return 404 when user is not found on avatar (go-gitea#21476) Enforce grouped NuGet search results (go-gitea#21442) Display total commit count in hook message (go-gitea#21400) Refactor GetNextResourceIndex to make it work properly with transaction (go-gitea#21469) Simplify fmt-check (go-gitea#21458) update current stable version 1.17.3 changelog [skip ci] Updated translations via Crowdin Fix mermaid-related bugs (go-gitea#21431) ...
This is precisely what I was questioning about above. We need still need to emit the create event - at least when the draft is finally undrafted (but then you're likely going to need to add a field on the release) |
That would make sense to do that... bummer it got merged already. |
Please send backport |
This reverts commit a37e8b2.
* giteaofficial/main: [skip ci] Updated translations via Crowdin Revert "Do not send notifications for draft releases (go-gitea#21451)" (go-gitea#21594) Change `commits-table` column width (go-gitea#21564)
Fixes #21448