Simplify fmt-check #21458
Simplify fmt-check #21458
Conversation
fmt-check now simly does fmt before and relies on 'git diff' like other checks like 'tidy-check' already do, so we can remove the argument in the tool that handles printing changed files.
silverwind
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 1
GiteaBot
added
lgtm/done
|
The |
|
Actually, after The misspell is never used, the only sub-command call to |
|
Right, I will add misspell again. |
|
Get this merged, or wait for your time? |
|
misspell seems be ran as part of golangci-lint now, so we can at least remove the remnants of it in misspell will not catch misspellings in JS/CSS files, I will check if something can be done to run it outside golangci-lint to fix that. |
|
Yup, I mean ... merge this PR now (it has got 2 approvals and is ready to merge), or wait for more time? 😂 |
|
Misspell now runs as part of |
|
Done, now misspell also picks up JS/CSS files and runs as a check only without autocorrection as that can be dangerous. |
|
--> Improve code format during build, remove code-batch-process #21471 |
* upstream/main: (32 commits) inline gitpod image (go-gitea#21494) [skip ci] Updated translations via Crowdin Do not send notifications for draft releases (go-gitea#21451) Update reverse-proxies.zh-cn.md (go-gitea#21484) Docs: Update the feature comparison to other Git Hosting Services (go-gitea#20933) Add some api integration tests (go-gitea#18872) probe if sha before exec git (go-gitea#21467) Fix incorrect notification commit url (go-gitea#21479) Localize all timestamps (go-gitea#21440) [skip ci] Updated translations via Crowdin Add system setting table with cache and also add cache supports for user setting (go-gitea#18058) Return 404 when user is not found on avatar (go-gitea#21476) Enforce grouped NuGet search results (go-gitea#21442) Display total commit count in hook message (go-gitea#21400) Refactor GetNextResourceIndex to make it work properly with transaction (go-gitea#21469) Simplify fmt-check (go-gitea#21458) update current stable version 1.17.3 changelog [skip ci] Updated translations via Crowdin Fix mermaid-related bugs (go-gitea#21431) ...
fmt-checknow simply doesfmtbefore and relies ongit difflike other checks like 'tidy-check' already do, so we can remove the argument in the tool that handles printing changed files.