Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FSFE REUSE for golang files #21840

Merged
merged 20 commits into from
Nov 27, 2022
Merged

Implement FSFE REUSE for golang files #21840

merged 20 commits into from
Nov 27, 2022

Conversation

flynnnnnnnnnn
Copy link
Contributor

fixes #16132

@flynnnnnnnnnn
Copy link
Contributor Author

I only changed comments, can someone help explain why CI is failing?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2022
@jolheiser
Copy link
Member

The errors in the CI should point them out, but for example https://github.com/go-gitea/gitea/pull/21840/files#diff-52617ef219e61332d7bc880cd52ab7f34e21fb813040907db1c210837ccc3e95

It looks like whatever you used to mass-replace also broke some of the package statements.

@flynnnnnnnnnn
Copy link
Contributor Author

Thank you @jolheiser. My find replace was on an exact string, but there were some lines that had extra text it was not commented any longer.

@flynnnnnnnnnn
Copy link
Contributor Author

@jolheiser I have fixed the tests so they now pass.

zeripath
zeripath approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if this is the way that the OSS ecosystem is going then we should do this.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2022
delvh
delvh approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm terribly sorry, GitHub, for DDOsing you with JS requests only to notice afterward that there were much easier options available…)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

Were you benefited from SPDX? Or just help it become a widely accepted standard.

I'm not against this PR.

@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit e81ccc4 into go-gitea:main Nov 27, 2022
@zeripath
Copy link
Contributor

zeripath commented Nov 27, 2022 •
edited
Loading

OK this is going to take some work to ensure that we remain compliant as we go forward. This means that we should probably add a REUSE compliance check to make check

@jolheiser
Copy link
Member

Was just about to post we should add this to our vet check

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 29, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0261a67 
* giteaofficial/main:
  Use random bytes to generate access token (go-gitea#21959)
  Replace fmt.Sprintf with hex.EncodeToString (go-gitea#21960)
  Implement FSFE REUSE for golang files (go-gitea#21840)
  Correct the fallbacks for mailer configuration (go-gitea#21945)
  [skip ci] Updated licenses and gitignores
  Fix typos (go-gitea#21947)
  Fix markdown anchor re-clicking (go-gitea#21931)
  Prevent NPE if trying to restore an already restored deleted branch (go-gitea#21940)
  add rel="me" to org.website link (go-gitea#21941)
@wolfogre
Copy link
Member

wolfogre commented Dec 1, 2022

OK this is going to take some work to ensure that we remain compliant as we go forward. This means that we should probably add a REUSE compliance check to make check

I think this may help: https://gitea.com/gitea/gitea-vet/pulls/21

I'll update the check of Gitea when the PR above has been merged.

@wolfogre wolfogre mentioned this pull request Dec 2, 2022
Merged
lunny added a commit that referenced this pull request Dec 2, 2022
@wolfogre @lunny
Update gitea-vet to check FSFE REUSE (#22004)
f59a748 
Related to:
- #21840
- https://gitea.com/gitea/gitea-vet/pulls/21

What it looks like when it's working:
https://drone.gitea.io/go-gitea/gitea/64040/1/5

All available SPDX license identifiers: [SPDX License
List](https://spdx.org/licenses/).

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@yardenshoham yardenshoham mentioned this pull request Dec 4, 2022
Merged
@flynnnnnnnnnn flynnnnnnnnnn deleted the fsfe-reuse branch December 10, 2022 04:07
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt REUSE best practices to clarify copyright and licensing
6 participants
@flynnnnnnnnnn @jolheiser @zeripath @wolfogre @delvh @GiteaBot