Prevent NPE if trying to restore an already restored deleted branch #21940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix go-gitea#21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
outdated/backport/v1.18
lunny
approved these changes
Nov 25, 2022
GiteaBot
added
the
lgtm/need 1
a1012112796
approved these changes
Nov 25, 2022
GiteaBot
added
lgtm/done
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Nov 25, 2022
…o-gitea#21940) Backport go-gitea#21940 If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix go-gitea#21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
pushed a commit
that referenced
this pull request
Nov 25, 2022
…21940) (#21944) Backport #21940 If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests. Fix #21930 Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2022
* giteaofficial/main: Use random bytes to generate access token (go-gitea#21959) Replace fmt.Sprintf with hex.EncodeToString (go-gitea#21960) Implement FSFE REUSE for golang files (go-gitea#21840) Correct the fallbacks for mailer configuration (go-gitea#21945) [skip ci] Updated licenses and gitignores Fix typos (go-gitea#21947) Fix markdown anchor re-clicking (go-gitea#21931) Prevent NPE if trying to restore an already restored deleted branch (go-gitea#21940) add rel="me" to org.website link (go-gitea#21941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a deleted-branch has already been restored, a request to restore it again will cause a NPE. This PR adds detection for this case, but also disables buttons when they're clicked in order to help prevent accidental repeat requests.
Fix #21930
Signed-off-by: Andrew Thornton art27@cantab.net