Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the full-height problem for all pages #22905

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

wxiaoguang
Copy link
Contributor

Really fix #22883, close #22901

I made a mistake that the global styles in RepoActionView.vue could still pollute global styles (I forgot that the code of this component is still loaded on every page, instead of loaded on demand)

This PR makes a complete fix: only change the page's full-height behavior if the component is used.

Screenshot after the fix:

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 14, 2023
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 14, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2023
@lunny
Copy link
Member

lunny commented Feb 14, 2023

LG-TM bot

@lunny lunny merged commit e314c9e into go-gitea:main Feb 14, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 14, 2023
@wxiaoguang wxiaoguang deleted the fix-full-height branch February 14, 2023 13:04
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 15, 2023
* upstream/main:
  Add command to bulk set must-change-password (go-gitea#22823)
  Remember to attach the parent tree when converting TreeEntry() -> Tree() (go-gitea#22902)
  Fix dark-colored description text in arc-green theme (go-gitea#22908)
  Fix the full-height problem for all pages (go-gitea#22905)
  Remove Fomantic-UI's `.hidden` CSS class for menu elements (go-gitea#22895)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incurrect ui in creating projects page Tracking issue for actions full-height CSS
4 participants