Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the full-height problem for all pages #22905

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix the full-height problem for all pages #22905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b99a187
fix
wxiaoguang Feb 14, 2023
50b4ccc
Merge branch 'main' into fix-full-height
lunny Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web_src/js/components/RepoActionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,11 @@ export function initRepositoryActionView() {
const el = document.getElementById('repo-action-view');
if (!el) return;

// TODO: the parent element's full height doesn't work well now,
// but we can not pollute the global style at the moment, only fix the height problem for pages with this component
const parentFullHeight = document.querySelector('body > div.full.height');
if (parentFullHeight) parentFullHeight.style.paddingBottom = '0';

const view = createApp(sfc, {
runIndex: el.getAttribute('data-run-index'),
jobIndex: el.getAttribute('data-job-index'),
Expand Down Expand Up @@ -412,11 +417,6 @@ export function initRepositoryActionView() {
<style lang="less">
// some elements are not managed by vue, so we need to use global style

// TODO: the parent element's full height doesn't work well now
body > div.full.height {
padding-bottom: 0;
}

.job-status-rotate {
animation: job-status-rotate-keyframes 1s linear infinite;
}
Expand Down