-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip DB tests duplicate runs on push to branches #23476
Skip DB tests duplicate runs on push to branches #23476
Conversation
Ah thanks, I was also looking at something for this. One thing, we may need the mysql pipeline to run still, as that includes our coverage report. |
This also partially covers #22011, though this doesn't cover tags afaict |
just update to skip tags.
I think we need to reflect on our coverage reports, and if they are in fact used/reviewed. |
With your latest changes, is it simpler to just remove Further, some of the release pipelines depend on these test pipelines, if they don't run does that need to change? I believe I just changed them to depend on |
Yes, it certainly would (you can see it in the testing-e2e pipeline), I went for an exclude if for some reason we need to push a branch that isn't main or release/* and want to run things. Definitely not the cleanest approach, and possibly am attempting to optimizing for something that may never happen. Happy to change if you (or others) have strong feelings about it.
So the fun (in a good way) thing is that drone will adjust the dag to accommodate for skipped pipelines (see: https://gitea.com/gitea/drone-test/src/branch/main/.drone.yml for an example of how this plays out in practice) |
LOLOL, yup. This doesn't work. I'll need to change it to the way you suggested @jolheiser |
I do think I prefer changing to removing Just my opinion, though, I'm fine with approving either once we get it passing. 🙂 |
@jolheiser my "LLOLOL" comment above was checking out the run, and seeing that drone uses the "branch" condition in the evaluation for PRs, so if I say "skip main" then it'll skip that pipeline for PRs attempting to merge into main. So the way you suggested is likely the only way to go. I've updated to just remove |
* giteaofficial/main: (33 commits) Bump webpack from 5.75.0 to 5.76.0 (go-gitea#23484) Replace Less with CSS (go-gitea#23481) Fix 'View File' button in code search (go-gitea#23478) Use `gitea/test_env` image instead of `golang` (go-gitea#23455) Skip DB tests duplicate runs on push to branches (go-gitea#23476) Update app.example.ini (go-gitea#23480) [skip ci] Updated translations via Crowdin Fix due date being wrong on issue list (go-gitea#23475) test_env: hardcode major go version in use (go-gitea#23464) Push option bonus for PTC docs (go-gitea#23473) Lint Markdown pass Push to create docs (go-gitea#23458) Convert GitHub event on actions and fix some pull_request events. (go-gitea#23037) Remove wrongly added column on migration test fixtures (go-gitea#23456) Refactor branch/tag selector to Vue SFC (go-gitea#23421) add admin API email endpoints (go-gitea#22792) add user rename endpoint to admin api (go-gitea#22789) Add workflow error notification in ui (go-gitea#23404) Make branches list page operations remember current page (go-gitea#23420) fix markdown lint issue (go-gitea#23457) ...
This skips all testing-* pipelines on push to main or release/* branches. This decreases the total build time on those, as in theory they should already be run for PRs before merging.
Fixes #22011