Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Close to either Close issue or Close pull request #23506

Merged
merged 9 commits into from
Mar 16, 2023

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Mar 15, 2023

Following a discord discussion, the close button in the issue comment box is more descriptive.

Before

For both issue and pull request
image

After

Issue

image

Pull request

image

@yardenshoham yardenshoham added this to the 1.20.0 milestone Mar 15, 2023
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Mar 15, 2023
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #23506 (a7212e7) into main (f521e88) will increase coverage by 0.01%.
The diff coverage is 44.37%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23506      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.01%     
==========================================
  Files        1149     1154       +5     
  Lines      151446   152195     +749     
==========================================
+ Hits        71397    71778     +381     
- Misses      71611    71950     +339     
- Partials     8438     8467      +29     
Impacted Files Coverage Δ
cmd/dump.go 0.67% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
models/user/search.go 77.50% <0.00%> (-6.29%) ⬇️
modules/actions/github.go 0.00% <0.00%> (ø)
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/doctor/storage.go 31.93% <0.00%> (ø)
modules/setting/git.go 45.45% <ø> (ø)
modules/storage/minio.go 1.51% <0.00%> (-0.06%) ⬇️
modules/structs/user.go 100.00% <ø> (ø)
... and 35 more

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 15, 2023
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
templates/repo/issue/view_content.tmpl Outdated Show resolved Hide resolved
templates/repo/issue/view_content.tmpl Outdated Show resolved Hide resolved
@brechtvl
Copy link
Contributor

The Gitea convention seems to be title case for buttons like these, so Close Issue and Close Pull Request?

@yardenshoham
Copy link
Member Author

The Gitea convention seems to be title case for buttons like these, so Close Issue and Close Pull Request?

Done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2023
@yardenshoham
Copy link
Member Author

Backport v1.19? Do we still have time?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2023
@lunny
Copy link
Member

lunny commented Mar 16, 2023

Backport v1.19? Do we still have time?

1.19.1 :)

@yardenshoham yardenshoham added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 16, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2023
@yardenshoham
Copy link
Member Author

I don't know why CI keeps failing on codecov

@lunny lunny merged commit 39d3711 into go-gitea:main Mar 16, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2023
@yardenshoham yardenshoham deleted the closed branch March 16, 2023 15:12
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 16, 2023
@yardenshoham
Copy link
Member Author

Ok no need to backport

@yardenshoham yardenshoham removed outdated/backport/v1.19 This PR should be backported to Gitea 1.19 backport/manual No power to the bots! Create your backport yourself! labels Mar 16, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 17, 2023
* giteaofficial/main:
  Use `<nav>` instead of `<div>` in the global navbar (go-gitea#23125)
  Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (go-gitea#23450)
  [skip ci] Updated translations via Crowdin
  Make time tooltips interactive (go-gitea#23526)
  Update mini-css-extract-plugin, remove postcss (go-gitea#23520)
  Fix review comment context menu clipped bug (go-gitea#23523)
  Add absent repounits to create/edit repo API (go-gitea#23500)
  Fix tags sort by creation time (descending) on branch/tag dropdowns  (go-gitea#23491)
  Allow both fullname and username search when `DEFAULT_SHOW_FULL_NAME` is true (go-gitea#23463)
  Handle files starting with colons in WalkGitLog (go-gitea#22935)
  Change `Close` to either `Close issue` or `Close pull request` (go-gitea#23506)
  Update act (go-gitea#23512)
  Move pidfile creation from setting to web cmd package (go-gitea#23285)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants