Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect visibility dropdown list in add/edit user page #23804

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Fix incorrect visibility dropdown list in add/edit user page #23804

merged 3 commits into from
Mar 30, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 30, 2023 •
edited
Loading

Visibility dropdown list will not work in add/edit user page when error occurred

@yp05327 yp05327 changed the title Fix incorrect visibility dropdown list in add user page Fix incorrect visibility dropdown list in add/edit user page Mar 30, 2023
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Mar 30, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #23804 (3a7f468) into main (f521e88) will decrease coverage by 0.13%.
The diff coverage is 28.82%.

@@            Coverage Diff             @@
##             main   #23804      +/-   ##
==========================================
- Coverage   47.14%   47.01%   -0.13%     
==========================================
  Files        1149     1158       +9     
  Lines      151446   153172    +1726     
==========================================
+ Hits        71397    72017     +620     
- Misses      71611    72655    +1044     
- Partials     8438     8500      +62
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
... and 64 more

... and 73 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2023
@jolheiser jolheiser enabled auto-merge (squash) March 30, 2023 15:06
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit c09eab5 into go-gitea:main Mar 30, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 30, 2023
@GiteaBot GiteaBot mentioned this pull request Mar 31, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 31, 2023
@yp05327 @GiteaBot
Fix incorrect visibility dropdown list in add/edit user page (go-gite…
def3543 
…a#23804)

Visibility dropdown list will not work in add/edit user page when error
occurred
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 31, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
c9ca0a0 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Fix dropdown direction behavior (go-gitea#23806)
  Fix incorrect/Improve error handle in edit user page (go-gitea#23805)
  Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (go-gitea#23790)
  Fix incorrect visibility dropdown list in add/edit user page (go-gitea#23804)
  Convert issue list checkboxes to native (go-gitea#23596)
  Fix checks for `needs` in Actions (go-gitea#23789)
  Diff improvements (go-gitea#23553)
  [Patch] Fix closed PR also triggers Webhooks and actions (go-gitea#23782)
  Improve backport-locales.go (go-gitea#23807)
  [skip ci] Updated translations via Crowdin
  Refactor commit status for Actions jobs (go-gitea#23786)
  Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (go-gitea#23766)
  Don't apply the group filter when listing LDAP group membership if it is empty (go-gitea#23745)
lunny pushed a commit that referenced this pull request Mar 31, 2023
@GiteaBot @yp05327
Fix incorrect visibility dropdown list in add/edit user page (#23804) (…
8b3dd7d 
…#23833)

Backport #23804 by @yp05327

Visibility dropdown list will not work in add/edit user page when error
occurred

Co-authored-by: yp05327 <576951401@qq.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@yp05327 @codecov-commenter @jolheiser @lunny @yardenshoham @delvh @techknowlogick @GiteaBot