-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect/Improve error handle in edit user page #23805
Merged
jolheiser
merged 2 commits into
go-gitea:main
from
yp05327:improve-error-handle-in-edit-user
Mar 30, 2023
Merged
Fix incorrect/Improve error handle in edit user page #23805
jolheiser
merged 2 commits into
go-gitea:main
from
yp05327:improve-error-handle-in-edit-user
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23805 +/- ##
==========================================
- Coverage 47.14% 47.00% -0.14%
==========================================
Files 1149 1158 +9
Lines 151446 153172 +1726
==========================================
+ Hits 71397 72004 +607
- Misses 71611 72678 +1067
- Partials 8438 8490 +52
... and 69 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 30, 2023
lunny
reviewed
Mar 30, 2023
lunny
approved these changes
Mar 30, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 30, 2023
silverwind
approved these changes
Mar 30, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 30, 2023
jolheiser
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 30, 2023
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 30, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Fix dropdown direction behavior (go-gitea#23806) Fix incorrect/Improve error handle in edit user page (go-gitea#23805) Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (go-gitea#23790) Fix incorrect visibility dropdown list in add/edit user page (go-gitea#23804) Convert issue list checkboxes to native (go-gitea#23596) Fix checks for `needs` in Actions (go-gitea#23789) Diff improvements (go-gitea#23553) [Patch] Fix closed PR also triggers Webhooks and actions (go-gitea#23782) Improve backport-locales.go (go-gitea#23807) [skip ci] Updated translations via Crowdin Refactor commit status for Actions jobs (go-gitea#23786) Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (go-gitea#23766) Don't apply the group filter when listing LDAP group membership if it is empty (go-gitea#23745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
RenderWithErr
should rendertplUserEdit
nottplUserNew
in edit pageHandleUsernameChange
redirect to original edit page instead of user list page