-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuration variables on Gitea Actions #24724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # models/migrations/migrations.go # models/migrations/v1_20/v255.go
# Conflicts: # models/migrations/migrations.go # models/migrations/v1_20/v256.go
# Conflicts: # web_src/js/index.js
# Conflicts: # web_src/js/index.js
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 15, 2023
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
May 15, 2023
3 tasks
yardenshoham
added
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
topic/gitea-actions
related to the actions of Gitea
labels
May 15, 2023
You should also implement this on the User Level |
silverwind
reviewed
May 15, 2023
wxiaoguang
reviewed
Jun 19, 2023
wxiaoguang
approved these changes
Jun 19, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jun 19, 2023
Regarding field names, do I understand that we have now Name/Data in database and Name/Value in UI, right? Is it like that for both secrets and variables? |
yes it is |
silverwind
approved these changes
Jun 20, 2023
silverwind
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jun 20, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jun 20, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 21, 2023
* giteaofficial/main: Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) Fetch all git data for embedding correct version in docker image (go-gitea#25361) Fix sidebar label dropdown divider (go-gitea#25359) Fix issue filters on mobile view (go-gitea#25368) Refactor: TotalTimest return seconds (go-gitea#25370)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 21, 2023
* origin/main: (47 commits) Move some regexp out of functions (go-gitea#25430) Show outdated comments in files changed tab (go-gitea#24936) Remove "CHARSET" config option for MySQL, always use "utf8mb4" (go-gitea#25413) Fine tune project board label colors and modal content background (go-gitea#25419) Fix missing commit message body when the message has leading newlines (go-gitea#25418) add python/poetry to devcontainer (go-gitea#25407) Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) ...
lunny
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
topic/gitea-actions
related to the actions of Gitea
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Author: @silverwind @wxiaoguang
Replace: #24404
See:
Related to:
Screenshoot
Create Variable:
Workflow:
Actions Log:
This PR just implement the org / user (depends on the owner of the current repository) and repo level variables, The Environment level variables have not been implemented.
Because Environment is a module separate from
Actions
. Maybe it would be better to create a new PR to do it.