Fix dropdown icon layout on diff page #25397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
force-pushed
the
fix-diff-dropdown
branch
from
2b850f4 to
387235a
Compare
wxiaoguang
force-pushed
the
fix-diff-dropdown
branch
from
387235a to
6b4941c
Compare
wxiaoguang
added
the
skip-changelog
|
Do away with the triangle there, the "..." button also does not have one despite opening a dropdown. |
|
This PR is doing without the dropdown icon. |
silverwind
approved these changes
Jun 20, 2023
GiteaBot
added
lgtm/need 1
silverwind
added
backport/v1.20
lafriks
approved these changes
Jun 20, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 20, 2023
Address go-gitea#25163 (comment) Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ```  With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ``` 
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Jun 21, 2023
Backport #25397 by @wxiaoguang Address #25163 (comment) Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ```  With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ```  Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 21, 2023
* giteaofficial/main: Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) Fetch all git data for embedding correct version in docker image (go-gitea#25361) Fix sidebar label dropdown divider (go-gitea#25359) Fix issue filters on mobile view (go-gitea#25368) Refactor: TotalTimest return seconds (go-gitea#25370)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 21, 2023
* origin/main: (47 commits) Move some regexp out of functions (go-gitea#25430) Show outdated comments in files changed tab (go-gitea#24936) Remove "CHARSET" config option for MySQL, always use "utf8mb4" (go-gitea#25413) Fine tune project board label colors and modal content background (go-gitea#25419) Fix missing commit message body when the message has leading newlines (go-gitea#25418) add python/poetry to devcontainer (go-gitea#25407) Refactor path & config system (go-gitea#25330) Add actor and status dropdowns to run list (go-gitea#25118) Use the new download domain replace the old (go-gitea#25405) Avoid polluting config file when "save" (go-gitea#25395) Fix dropdown icon layout on diff page (go-gitea#25397) Support configuration variables on Gitea Actions (go-gitea#24724) Substitute variables in path names of template repos too (go-gitea#25294) Navbar styling rework (go-gitea#25343) Fix blank dir message when uploading files from web editor (go-gitea#25391) Add git-lfs support to devcontainer (go-gitea#25385) Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite (go-gitea#25386) Use Actions git context instead of dynamically created buildkit one (go-gitea#25381) rename tributeValues to mentionValues (go-gitea#25375) Fix LDAP sync when Username Attribute is empty (go-gitea#25278) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #25163 (comment)
Remove the unused "icon-button".
And fix the layout:
Without the dropdown icon:
With the dropdown icon: