Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown icon layout on diff page (#25397) #25403

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix dropdown icon layout on diff page (#25397) #25403

merged 1 commit into from
Jun 21, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #25397 by @wxiaoguang

Address #25163 (comment)

Remove the unused "icon-button".

And fix the layout:

Without the dropdown icon:

	{{svg "gitea-whitespace"}}

image

With the dropdown icon:

	{{svg "gitea-whitespace" 16 "gt-mr-3"}}
	{{svg "octicon-triangle-down" 14 "dropdown icon"}}

image

@wxiaoguang @GiteaBot
Fix dropdown icon layout on diff page (go-gitea#25397)
df25ce4 
Address
go-gitea#25163 (comment)

Remove the unused  "icon-button".

And fix the layout:

Without the dropdown icon:

```
	{{svg "gitea-whitespace"}}
```


![image](https://github.com/go-gitea/gitea/assets/2114189/58a524ba-f289-4982-aea2-6f9f9f9cbdcf)


With the dropdown icon:

```
	{{svg "gitea-whitespace" 16 "gt-mr-3"}}
	{{svg "octicon-triangle-down" 14 "dropdown icon"}}
```


![image](https://github.com/go-gitea/gitea/assets/2114189/eb99168b-5d49-40a7-8665-5296cbb4e486)
@GiteaBot GiteaBot added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 20, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 20, 2023
@GiteaBot GiteaBot requested review from lafriks and silverwind June 20, 2023 23:22
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2023
@lunny lunny merged commit cda69a0 into go-gitea:release/v1.20 Jun 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@lafriks lafriks Awaiting requested review from lafriks

@silverwind silverwind Awaiting requested review from silverwind

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @wxiaoguang