Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 error caused by notifications without an issue such as repo transfers #25101

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix 500 error caused by notifications without an issue such as repo transfers #25101

merged 1 commit into from
Jun 6, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Jun 6, 2023

Fix #25100.

@wolfogre wolfogre added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Jun 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2023
@wolfogre wolfogre changed the title Fix 500 error caused by notifications without an issue, such as notifications about repository transfers Fix 500 error caused by notifications without an issue such as repository transfers Jun 6, 2023
@wolfogre wolfogre changed the title Fix 500 error caused by notifications without an issue such as repository transfers Fix 500 error caused by notifications without an issue such as repo transfers Jun 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2023
@lunny lunny merged commit 379ec13 into go-gitea:main Jun 6, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 6, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Jun 6, 2023

I was unable to create a backport for 1.19. @wolfogre, please send one manually. 🍵

go run ./contrib/backport 25101
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Jun 6, 2023
@wolfogre
Copy link
Member Author

wolfogre commented Jun 8, 2023

I was unable to create a backport for 1.19. @wolfogre, please send one manually. 🍵

go run ./contrib/backport 25101
...  // fix git conflicts if any
go run ./contrib/backport --continue

My bad, there is no such bug in v1.19. Confirmed.

@wolfogre wolfogre removed outdated/backport/v1.19 This PR should be backported to Gitea 1.19 backport/manual No power to the bots! Create your backport yourself! labels Jun 8, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 9, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
482bdb7 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Modify OAuth login ui and fix display name, iconurl related logic (go-gitea#25030)
  Fix open redirect check for more cases (go-gitea#25143)
  Update js dependencies (go-gitea#25137)
  Remove duplicated functions when deleting a branch (go-gitea#25128)
  Add codeowners feature (go-gitea#24910)
  Fix strange UI behavior of cancelling dismiss review modal (go-gitea#25133)
  Fix `MilestoneIDs` when querying issues (go-gitea#25125)
  Fix incorrect git ignore rule and add missing license files (go-gitea#25135)
  Change branch name from master to main in some documents' links (go-gitea#25126)
  Remove incorrect element ID on "post-install" page (go-gitea#25104)
  [skip ci] Updated translations via Crowdin
  Improve notification icon and navbar  (go-gitea#25111)
  fix swagger documentation for multiple files API endpoint (go-gitea#25110)
  Fix webauthn regression and improve code (go-gitea#25113)
  Add details summary for vertical menus in settings to allow toggling (go-gitea#25098)
  Fix 500 error caused by notifications without an issue such as repo transfers (go-gitea#25101)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Notifications about repository transfers will cause 500 error
5 participants
@wolfogre @GiteaBot @lunny @Zettat123 @delvh