Remove incorrect element ID on "post-install" page #25104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
approved these changes
Jun 6, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jun 6, 2023
GiteaBot
added
lgtm/done
|
Why "removed this from the 1.20.0 milestone Jun 8, 2023" .... This is a pretty simple and useful bug fix ( |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 8, 2023
That ID is a "copy&paste" error, it conflicts with the `initRepoMigrationStatusChecker` logic, which is the right function for a real `#repo_migrating` element. That wrong ID causes incorrect page navigation after installation.
silverwind
pushed a commit
that referenced
this pull request
Jun 8, 2023
Backport #25104 by @wxiaoguang That ID is a "copy&paste" error, it conflicts with the `initRepoMigrationStatusChecker` logic, which is the right function for a real `#repo_migrating` element. That wrong ID causes incorrect page navigation after installation. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jun 8, 2023
* main: Modify OAuth login ui and fix display name, iconurl related logic (go-gitea#25030) Fix open redirect check for more cases (go-gitea#25143) Update js dependencies (go-gitea#25137) Remove duplicated functions when deleting a branch (go-gitea#25128) Add codeowners feature (go-gitea#24910) Fix strange UI behavior of cancelling dismiss review modal (go-gitea#25133) Fix `MilestoneIDs` when querying issues (go-gitea#25125) Fix incorrect git ignore rule and add missing license files (go-gitea#25135) Change branch name from master to main in some documents' links (go-gitea#25126) Remove incorrect element ID on "post-install" page (go-gitea#25104) [skip ci] Updated translations via Crowdin Improve notification icon and navbar (go-gitea#25111) fix swagger documentation for multiple files API endpoint (go-gitea#25110)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 9, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Modify OAuth login ui and fix display name, iconurl related logic (go-gitea#25030) Fix open redirect check for more cases (go-gitea#25143) Update js dependencies (go-gitea#25137) Remove duplicated functions when deleting a branch (go-gitea#25128) Add codeowners feature (go-gitea#24910) Fix strange UI behavior of cancelling dismiss review modal (go-gitea#25133) Fix `MilestoneIDs` when querying issues (go-gitea#25125) Fix incorrect git ignore rule and add missing license files (go-gitea#25135) Change branch name from master to main in some documents' links (go-gitea#25126) Remove incorrect element ID on "post-install" page (go-gitea#25104) [skip ci] Updated translations via Crowdin Improve notification icon and navbar (go-gitea#25111) fix swagger documentation for multiple files API endpoint (go-gitea#25110) Fix webauthn regression and improve code (go-gitea#25113) Add details summary for vertical menus in settings to allow toggling (go-gitea#25098) Fix 500 error caused by notifications without an issue such as repo transfers (go-gitea#25101)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That ID is a "copy&paste" error, it conflicts with the
initRepoMigrationStatusCheckerlogic, which is the right function for a real#repo_migratingelement. That wrong ID causes incorrect page navigation after installation.