Remove incorrect element ID on "post-install" page (#25104) #25129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That ID is a "copy&paste" error, it conflicts with the `initRepoMigrationStatusChecker` logic, which is the right function for a real `#repo_migrating` element. That wrong ID causes incorrect page navigation after installation.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jun 8, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #25104 by @wxiaoguang
That ID is a "copy&paste" error, it conflicts with the
initRepoMigrationStatusCheckerlogic, which is the right function for a real#repo_migratingelement. That wrong ID causes incorrect page navigation after installation.