-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add note that PROTOCOL config is case-sensitive #25685
Merged
lunny
merged 3 commits into
go-gitea:main
from
MiloCubed:MiloCubed-docs-protocol-lowercase
Oct 19, 2023
Merged
[docs] Add note that PROTOCOL config is case-sensitive #25685
lunny
merged 3 commits into
go-gitea:main
from
MiloCubed:MiloCubed-docs-protocol-lowercase
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 4, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jul 4, 2023
delvh
reviewed
Jul 4, 2023
delvh
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state seems acceptable to me, especially if relref
supports URL fragments.
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 5, 2023
lunny
reviewed
Jul 28, 2023
github-actions
bot
added
modifies/translation
modifies/api
This PR adds API routes or modifies them
modifies/cli
PR changes something on the CLI, i.e. gitea doctor or gitea admin
modifies/frontend
modifies/docs
modifies/migrations
modifies/internal
labels
Oct 19, 2023
lunny
force-pushed
the
MiloCubed-docs-protocol-lowercase
branch
from
October 19, 2023 08:13
07c8b97
to
7bbb0e0
Compare
github-actions
bot
removed
modifies/translation
modifies/api
This PR adds API routes or modifies them
modifies/cli
PR changes something on the CLI, i.e. gitea doctor or gitea admin
modifies/frontend
modifies/migrations
modifies/internal
labels
Oct 19, 2023
lunny
approved these changes
Oct 19, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 19, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 20, 2023
* upstream/main: Adapt `.changelog.yml` to new labeling system (go-gitea#27701) Update and add new eslint plugins (go-gitea#27698) Show total TrackedTime on issue/pull/milestone lists (go-gitea#26672) Add doctor dbconsistency fix to delete repos with no owner (go-gitea#27290) Delete repos of org when purge delete user (go-gitea#27273) Fix required checkboxes in issue forms (go-gitea#27592) Upgrade xorm (go-gitea#27673) [docs] Add note that PROTOCOL config is case-sensitive (go-gitea#25685) Remove network call on `make clean` (go-gitea#27689) Add unit tests for action runner token (go-gitea#27670) Typos fixed in documentation files (go-gitea#27687)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/docs
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
type/docs
This PR mainly updates/creates documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue on gitea.com, copied below for convenience:
For this PR I added the note in the Config Cheat Sheet page and fixed the links to it from the HTTPS Setup page.
Was originally thinking to put the note in the HTTPS Setup page itself, but since there are 2 sections referencing the PROTOCOL config, I was thinking it'd be neater and more concise to put it in the Config Cheat Sheet page instead. Especially since both sections already link to it, and I actually tried to check that link quite early on in my troubleshooting (but didn't pay much attention to it since the link was broken).
Before/After screenshots as per this repo's docs
Before - links
Note: For this the links weren't broken, the links fix is because they were broken on gitea.com's docs (see below).
After - links
Before - config cheat sheet
After - config cheat sheet
Before/After screenshots as per gitea.com's docs
Before - links
After - links
Before - config cheat sheet
After - config cheat sheet