Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctor dbconsistency fix to delete repos with no owner #27290

Merged
merged 20 commits into from
Oct 19, 2023
Merged

Add doctor dbconsistency fix to delete repos with no owner #27290

merged 20 commits into from
Oct 19, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 26, 2023 •
edited by lunny
Loading

to address #27273
replace #24873

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2023
6543
6543 commented Sep 26, 2023
View reviewed changes
modules/doctor/repository.go Outdated Show resolved Hide resolved
@6543 6543 added the pr/wip This PR is not ready for review label Sep 26, 2023
@6543 6543 changed the title Add doctor dbconsistency fix to delete repos with no owner WIP: Add doctor dbconsistency fix to delete repos with no owner Sep 26, 2023
@6543 6543 changed the title WIP: Add doctor dbconsistency fix to delete repos with no owner Add doctor dbconsistency fix to delete repos with no owner Sep 26, 2023
@6543 6543 removed the pr/wip This PR is not ready for review label Sep 26, 2023
techknowlogick
techknowlogick approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be backported?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2023
@6543
Copy link
Member Author

6543 commented Sep 26, 2023

that one probably ...

@6543 6543 added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 26, 2023
@6543 6543 added this to the 1.22.0 milestone Sep 26, 2023
@6543
Copy link
Member Author

6543 commented Sep 26, 2023

not sure witch label is apropriate: enhancement or bugfix ... but most likely first one as it extends doctor

@6543 6543 added the type/enhancement An improvement of existing functionality label Sep 26, 2023
@wxiaoguang
Copy link
Contributor

Related:

@6543 6543 added the pr/wip This PR is not ready for review label Sep 30, 2023
@6543 6543 requested a review from lunny September 30, 2023 15:05
@6543 6543 removed the pr/wip This PR is not ready for review label Sep 30, 2023
6543
6543 commented Sep 30, 2023
View reviewed changes
modules/doctor/repository.go Outdated Show resolved Hide resolved
6543
6543 commented Sep 30, 2023
View reviewed changes
services/repository/delete.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from lunny October 16, 2023 17:13
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2023
@6543 6543 enabled auto-merge (squash) October 19, 2023 12:39
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 19, 2023
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 19, 2023
@6543
Add doctor dbconsistency fix to delete repos with no owner (go-gitea#…
0ed31ee 
…27290)
@6543 6543 mentioned this pull request Oct 19, 2023
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Oct 19, 2023
@6543
Copy link
Member Author

6543 commented Oct 19, 2023

-> #27693

This was referenced Oct 19, 2023
Closed
Closed
@6543 6543 disabled auto-merge October 19, 2023 13:20
@6543 6543 merged commit e83f2cb into go-gitea:main Oct 19, 2023
25 checks passed
@6543 6543 deleted the doctor_delete_orphaned_repos branch October 19, 2023 13:20
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 19, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 20, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
8879756 
* upstream/main:
  Adapt `.changelog.yml` to new labeling system (go-gitea#27701)
  Update and add new eslint plugins (go-gitea#27698)
  Show total TrackedTime on issue/pull/milestone lists (go-gitea#26672)
  Add doctor dbconsistency fix to delete repos with no owner (go-gitea#27290)
  Delete repos of org when purge delete user (go-gitea#27273)
  Fix required checkboxes in issue forms (go-gitea#27592)
  Upgrade xorm (go-gitea#27673)
  [docs] Add note that PROTOCOL config is case-sensitive (go-gitea#25685)
  Remove network call on `make clean` (go-gitea#27689)
  Add unit tests for action runner token (go-gitea#27670)
  Typos fixed in documentation files (go-gitea#27687)
6543 added a commit that referenced this pull request Oct 22, 2023
@6543
Add doctor dbconsistency fix to delete repos with no owner (#27290) (#…
aabcf2d 
…27693)

Backport #27290
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @wxiaoguang @lunny @silverwind @techknowlogick @GiteaBot