Remove ref name in PR commits page #25876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
yp05327
changed the title
yp05327
changed the title
|
Why not just remove it from template? |
It uses |
|
I don't think this is the right way to fix that problem. |
pull-request-size
bot
added
size/S
|
Checked all usages, it seems that we can remove it from template safely. |
lunny
reviewed
Jul 14, 2023
routers/web/web.go
Outdated
| @@ -1280,7 +1280,7 @@ func registerRoutes(m *web.Route) { | |||
| m.Get("", repo.SetWhitespaceBehavior, repo.GetPullDiffStats, repo.ViewIssue) | |||
| m.Get(".diff", repo.DownloadPullDiff) | |||
| m.Get(".patch", repo.DownloadPullPatch) | |||
| m.Get("/commits", context.RepoRef(), repo.SetWhitespaceBehavior, repo.GetPullDiffStats, repo.ViewPullCommits) | |||
There was a problem hiding this comment.
Does this really need to be removed?
There was a problem hiding this comment.
I think this can be removed here, but if you think this is not safe, we can keep it.
|
Since the commit table is shared by some pages, could you also have screenshots for other commits pages? |
|
commits_table.tmpl is used in 3 places. Repo Commit Page: New PR page: no changes |
lunny
added
the
topic/ui-interaction
lunny
approved these changes
Aug 9, 2023
GiteaBot
added
lgtm/need 1
puni9869
approved these changes
Aug 23, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 24, 2023
* upstream/main: feat(API): update and delete secret for managing organization secrets (go-gitea#26660) Remove ref name in PR commits page (go-gitea#25876) Modify the content format of the Feishu webhook (go-gitea#25106) Handle "comment form combo editor init" more gracefully (go-gitea#26688) Prefer variables over subprocesses (go-gitea#26690) Fix archived unix time when archiving the label (go-gitea#26681) Make "link-action" backend code respond correct JSON content (go-gitea#26680) Fix doubled box-shadow in branch dropdown menu (go-gitea#26678) Refactor toast module (go-gitea#26677)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch name display here is based on the repo's default branch which is not correct.
For example, if I changed the default branch, the branch name here will also be changed:
you can confirm this in :
https://try.gitea.io/yp05327/testrepo/pulls/1/commits
I think we do not need to display branch name here, as we already have the branch info above.
