Prefer variables over subprocesses #26690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because it doesn't require a separate shell, spawning a process which cost unnecessary resources and takes time.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
approved these changes
Aug 23, 2023
GiteaBot
added
lgtm/need 1
delvh
added
type/docs
|
I think one could even use |
silverwind
approved these changes
Aug 23, 2023
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 23, 2023
… because it doesn't require a separate shell, spawning a process which cost unnecessary resources and takes time.
silverwind
pushed a commit
that referenced
this pull request
Aug 23, 2023
Backport #26690 by @thomas-mc-work … because it doesn't require a separate shell, spawning a process which cost unnecessary resources and takes time. Co-authored-by: Thomas McWork <thomas.mc.work@posteo.de>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 24, 2023
* upstream/main: feat(API): update and delete secret for managing organization secrets (go-gitea#26660) Remove ref name in PR commits page (go-gitea#25876) Modify the content format of the Feishu webhook (go-gitea#25106) Handle "comment form combo editor init" more gracefully (go-gitea#26688) Prefer variables over subprocesses (go-gitea#26690) Fix archived unix time when archiving the label (go-gitea#26681) Make "link-action" backend code respond correct JSON content (go-gitea#26680) Fix doubled box-shadow in branch dropdown menu (go-gitea#26678) Refactor toast module (go-gitea#26677)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… because it doesn't require a separate shell, spawning a process which cost unnecessary resources and takes time.