Return empty when searching issues with no repos #26545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/M
wolfogre
commented
Aug 16, 2023
wolfogre
changed the title
pull-request-size
bot
added
size/S
delvh
approved these changes
Aug 17, 2023
GiteaBot
added
lgtm/need 1
wolfogre
referenced
this pull request
Aug 17, 2023
Fix `https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
referenced
this pull request
in GiteaBot/gitea
Aug 17, 2023
Fix `https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
silverwind
referenced
this pull request
Aug 17, 2023
Backport #26556 by @wolfogre Fix `https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340` Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
approved these changes
Aug 17, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
silverwind
reviewed
Aug 17, 2023
| // no repos found, don't let the indexer return all repos | ||
| opts.RepoIDs = []int64{0} | ||
| } | ||
| } |
There was a problem hiding this comment.
Curious, what's this {} syntax? Is this a on-demand closure like in JS?
There was a problem hiding this comment.
It's an int64 slice literal with a single value 0 in it.
There was a problem hiding this comment.
Not that one, I meant the enclosing {} between lines 460 and 471.
There was a problem hiding this comment.
Found it, it's called Block: https://go.dev/ref/spec#Blocks, same as in JS, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/block
There was a problem hiding this comment.
Never mind, it is just a trick. I usually do this in a relatively separate piece of code, to avoid polluting a broader scope with local variables, especially when the function body is large.
buildIssueOverview is so big, it has almost 400 lines and at least 20 local variables.
Explicit blocks also make it clear how to refactor them to multiple functions, but I'm too lazy to refactor it right now 😁
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 18, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Fix various line-height styles (go-gitea#26553) Return empty when searching issues with no repos (go-gitea#26545) Support rebuilding issue indexer manually (go-gitea#26546) Fix label filter between `all` and `no` (go-gitea#26557) Fix "issueReposQueryPattern does not match query" (go-gitea#26556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26512.
Replace and close #26515.
Regression of #26012.
After this: