Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label filter between all and no #26557

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fix label filter between all and no #26557

merged 3 commits into from
Aug 17, 2023

Conversation

CaiCandong
Copy link
Member

@CaiCandong CaiCandong commented Aug 17, 2023 •
edited
Loading

Regression of #25886.

Description

For labelIDs:

gitea/routers/web/repo/issue.go

Lines 171 to 174 in 9afcb0e

var labelIDs []int64
// 1,-2 means including label 1 and excluding label 2
// 0 means issues with no label
// blank means labels will not be filtered for issues

  • nil mean no filter
  • [0] mean no label filter

When selectLabels == "0", labelIDs should be [0] rather than nil

Before:

Before.mp4

After:

After.mp4

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2023
@CaiCandong CaiCandong requested a review from yp05327 August 17, 2023 03:03
yp05327
yp05327 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@yp05327 yp05327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. Thanks for the fix.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2023
@wolfogre wolfogre added this to the 1.21.0 milestone Aug 17, 2023
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 17, 2023
delvh
delvh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that skip-changelog?

@delvh delvh added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 17, 2023
@silverwind silverwind enabled auto-merge (squash) August 17, 2023 12:40
@silverwind silverwind merged commit 940f997 into go-gitea:main Aug 17, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 17, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 18, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
557ecc5 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Fix various line-height styles (go-gitea#26553)
  Return empty when searching issues with no repos (go-gitea#26545)
  Support rebuilding issue indexer manually (go-gitea#26546)
  Fix label filter between `all` and `no` (go-gitea#26557)
  Fix "issueReposQueryPattern does not match query" (go-gitea#26556)
@CaiCandong CaiCandong deleted the fix-label-filter-between-all-and-no branch September 4, 2023 12:40
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

@yp05327 yp05327 yp05327 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CaiCandong @wolfogre @yp05327 @delvh @puni9869 @silverwind @GiteaBot