Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(API): add route and implementation for creating/updating repository secret #26766

Merged
merged 14 commits into from
Aug 29, 2023
Merged

feat(API): add route and implementation for creating/updating repository secret #26766

merged 14 commits into from
Aug 29, 2023

Conversation

appleboy
Copy link
Member

spec: https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28#create-or-update-a-repository-secret

  • Add a new route for creating or updating a secret value in a repository
  • Create a new file routers/api/v1/repo/action.go with the implementation of the CreateOrUpdateSecret function
  • Update the Swagger documentation for the updateRepoSecret operation in the v1_json.tmpl template file

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023
@appleboy appleboy added the modifies/api This PR adds API routes or modifies them label Aug 28, 2023
@appleboy appleboy added this to the 1.21.0 milestone Aug 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2023
@appleboy
feat: add route and implementation for creating/updating repository s…
5cfbcf4 
…ecret

- Add a new route for creating or updating a secret value in a repository
- Create a new file `routers/api/v1/repo/action.go` with the implementation of the `CreateOrUpdateSecret` function
- Update the Swagger documentation for the `updateRepoSecret` operation in the `v1_json.tmpl` template file

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
feat: refactor secret creation and update functionality
52735c7 
- Add a new function `CreateOrUpdateSecret` in `models/secret/secret.go`
- Fix a typo in the function name `CreateOrUpdateOrgSecret` to `CreateOrUpdateSecret` in `routers/api/v1/repo/action.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
refactor: refactor secret creation and update logic
62bede0 
- Modify the function `CreateOrUpdateOrgSecret` in `routers/api/v1/org/action.go`
- Replace the call to `secret_model.UpdateSecret` with `secret_model.CreateOrUpdateSecret`
- Remove the block of code that handles the case when the secret is not found
- Remove the call to `secret_model.InsertEncryptedSecret`
- Add a new variable `isCreated` to check if the secret was created or updated
- Update the error handling for the function `CreateOrUpdateOrgSecret`
- Modify the function `CreateOrUpdateSecret` in `routers/api/v1/repo/action.go`
- Replace the call to `secret_model.UpdateSecret` with `secret_model.CreateOrUpdateSecret`
- Remove the block of code that handles the case when the secret is not found
- Remove the call to `secret_model.InsertEncryptedSecret`
- Add a new variable `isCreated` to check if the secret was created or updated
- Update the error handling for the function `CreateOrUpdateSecret`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
refactor: refactor function names in API and org package
8438a0c 
- Change the `CreateOrUpdateOrgSecret` function name to `CreateOrUpdateSecret` in `routers/api/v1/api.go`
- Change the `CreateOrUpdateOrgSecret` function name to `CreateOrUpdateSecret` in `routers/api/v1/org/action.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
wxiaoguang
wxiaoguang approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the CreateOrUpdateSecret api handler could also be simplified to a shared function (including: check name, call CreateOrUpdateSecret, make response), it also could be done later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 29, 2023
@puni9869
Copy link
Member

lets roll 💯

@silverwind silverwind enabled auto-merge (squash) August 29, 2023 20:37
@silverwind silverwind merged commit b91057b into go-gitea:main Aug 29, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 29, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 30, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
91a5317 
* giteaofficial/main:
  Use `Set[Type]` instead of `map[Type]bool/struct{}`. (go-gitea#26804)
  Fix verifyCommits error when push a new branch (go-gitea#26664)
  Fix Uint8Array comparisons and update vitest (go-gitea#26805)
  Add various missing files-changed dependencies (go-gitea#26799)
  Improve flex list item padding (go-gitea#26779)
  Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (go-gitea#26759)
  feat(API): add route and implementation for creating/updating repository secret (go-gitea#26766)
  Replace deprecated `elliptic.Marshal` (go-gitea#26800)
  Updating the js libraries to latest version. (go-gitea#26795)
  Fix some slice append usages (go-gitea#26778)
  Use Go 1.21 for golangci-lint (go-gitea#26786)
  Fix notification circle (border-radius) (go-gitea#26794)
  Fix context filter has no effect in dashboard (go-gitea#26695)
  Add default label in branch select list (go-gitea#26697)
  Remove redundant nil check in `WalkGitLog` (go-gitea#26773)
  Remove fomantic `item` module (go-gitea#26775)
  Update info regarding internet connection for build (go-gitea#26776)
  Fix being unable to use a repo that prohibits accepting PRs as a PR source. (go-gitea#26785)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@appleboy @puni9869 @lunny @wxiaoguang @silverwind @GiteaBot