Fix notification circle (border-radius) #26794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-notification-circle
branch
from
752bca7 to
13271e9
Compare
wxiaoguang
force-pushed
the
fix-notification-circle
branch
from
13271e9 to
a712c07
Compare
|
What will be single digit notification looks like. could you share a screenshot for that. |
puni9869
approved these changes
Aug 29, 2023
GiteaBot
added
lgtm/need 1
The same as before, no change.
|
|
silverwind
reviewed
Aug 29, 2023
| min-height: 17px; | ||
| border-radius: var(--border-radius-circle); | ||
| height: 17px; | ||
| border-radius: 11px; /* (height + 2 * borderThickness) / 2 */ |
There was a problem hiding this comment.
Not sure about the comment but value is right, matching height.
There was a problem hiding this comment.
It (the comment) is right, just rounds up.
Actually, border-radius: could be any large enough value, like 1000px
There was a problem hiding this comment.
Ah I missed that you changed value as well. Well let's hope it works :)
silverwind
approved these changes
Aug 29, 2023
GiteaBot
added
lgtm/done
|
🚀 let's roll. |
puni9869
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 30, 2023
* giteaofficial/main:
Use `Set[Type]` instead of `map[Type]bool/struct{}`. (go-gitea#26804)
Fix verifyCommits error when push a new branch (go-gitea#26664)
Fix Uint8Array comparisons and update vitest (go-gitea#26805)
Add various missing files-changed dependencies (go-gitea#26799)
Improve flex list item padding (go-gitea#26779)
Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (go-gitea#26759)
feat(API): add route and implementation for creating/updating repository secret (go-gitea#26766)
Replace deprecated `elliptic.Marshal` (go-gitea#26800)
Updating the js libraries to latest version. (go-gitea#26795)
Fix some slice append usages (go-gitea#26778)
Use Go 1.21 for golangci-lint (go-gitea#26786)
Fix notification circle (border-radius) (go-gitea#26794)
Fix context filter has no effect in dashboard (go-gitea#26695)
Add default label in branch select list (go-gitea#26697)
Remove redundant nil check in `WalkGitLog` (go-gitea#26773)
Remove fomantic `item` module (go-gitea#26775)
Update info regarding internet connection for build (go-gitea#26776)
Fix being unable to use a repo that prohibits accepting PRs as a PR source. (go-gitea#26785)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
border-radiusmeansradius, notdiameter, so it should be50%andboxHeight / 2