Change katex limits

[KN4CK3R]

Fixes #27812

Use higher defaults again but limit the input size.

[KN4CK3R]

Do we want a setting for this like with Mermaid?

gitea/web_src/js/markup/mermaid.js

Line 5 in 5a76759

const {mermaidMaxSourceCharacters} = window.config;

[delvh]

I'm not a fan of this addition.
Isn't 1000 chars too restrictive?
That's only four tweets, and there are many comments larger than that.
Even more so if they contain latex code which spikes char usage up tremendously.
Especially as that is per comment instead of per recognized latex string.

As I see it, we can either remove it, or we choose the value that GitLab for example uses.

[KN4CK3R]

GitLab uses 1000. Why do you think it's the whole comment? source is just the <code> block with the math code.

[delvh]

Ah, I should have expanded the code a little.
The el.textContent looked to me like it would be the whole comment, not the math block.

[delvh]

Ah, I should have expanded the code a little.
The el.textContent looked to me like it would be the whole comment, not the math block.

[nschloe]

Just noting that there are math expressions out there that are more than a thousand characters long. Just hit

\begin{align*}
S^{\prime} & :=\left\{i\ \colon u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{\frac{2}{3}(x_{i}+x_{i-1})})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{\frac{2}{3}(x_{i+1}+x_{i})})\right\},\\
S^{\prime}_{+} & :=\Big\{ i:u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{\frac{2}{3}(x_{i}+x_{i-1})})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{x_{i}}),\textrm{ or }\\
 & \mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{x_{i}})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{\frac{2}{3}(x_{i+1}+x_{i})})\Big\} ,\\
S^{\prime}_{++} & :=\Big\{ i:u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{x_{i}})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{x_{i}})\Big\} ,\textrm{ and}\\
S^{\prime}_{-} & :=\Big\{ i:u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{\frac{2}{3}(x_{i}+x_{i-1})})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{x_{i+1}}),\textrm{ or }\\
 & \mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}\mathrel{\phantom{=}}{}u_{2}(n^{x_{i}},n^{x_{i-1}})=O(n^{x_{i-1}})\textrm{ and }u_{2}(n^{x_{i+1}},n^{x_{i}})=O(n^{\frac{2}{3}(x_{i+1}+x_{i})})\Big\} .
\end{align*}

(1108 chars.)

[KN4CK3R]

I'm sure there are long expressions but I'm not sure if Gitea comments are the correct place for them. In this case you could just split the block into two blocks with two lines.

[nschloe]

Those appear in the README, as a translation of a scientific article, not in comments. I have no control over the size of the math blocks.

[silverwind]

Happy to accept a PR that increases these limits further. As I understand it there should be some limit to prevent performance impact from malicious comments etc, no other reason for those limits.