Fix bad method call when deleting user secrets via API #27829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/api
KN4CK3R
approved these changes
Oct 29, 2023
GiteaBot
added
lgtm/need 1
|
Would not have happened if there were tests 😬 |
delvh
approved these changes
Oct 29, 2023
GiteaBot
added
lgtm/done
KN4CK3R
added
backport/v1.21
|
@GiteaBot why you not backport |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 29, 2023
Fixed a little mistake when you deleting user secrets via the API. Found it when working on go-gitea#27725. It should be backported to 1.21 I think.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 30, 2023
* giteaofficial/main: List all Debian package versions in `Packages` (go-gitea#27786) Fix merge base commit for fast-forwarded GitLab PRs (go-gitea#27825) Fix bad method call when deleting user secrets via API (go-gitea#27829) Change katex limits (go-gitea#27823) Dockerfile small refactor (go-gitea#27757) Use GitLab's squash_commit_sha when available (go-gitea#27824) [skip ci] Updated translations via Crowdin Upgrade xorm to 1.3.4 (go-gitea#27807)
lunny
pushed a commit
that referenced
this pull request
Oct 31, 2023
Adds the missing user secrets API integration tests so #27829 does not happen again
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 31, 2023
Adds the missing user secrets API integration tests so go-gitea#27829 does not happen again
techknowlogick
pushed a commit
that referenced
this pull request
Oct 31, 2023
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Fixed a little mistake when you deleting user secrets via the API. Found it when working on go-gitea#27725. It should be backported to 1.21 I think.
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Adds the missing user secrets API integration tests so go-gitea#27829 does not happen again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a little mistake when you deleting user secrets via the API. Found it when working on #27725.
It should be backported to 1.21 I think.