-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Show/hide filetree button on small displays #27881
Merged
wxiaoguang
merged 6 commits into
go-gitea:main
from
sebastian-sauer:bugfix/fix_file_tree_button_small_displays
Nov 17, 2023
Merged
Fix Show/hide filetree button on small displays #27881
wxiaoguang
merged 6 commits into
go-gitea:main
from
sebastian-sauer:bugfix/fix_file_tree_button_small_displays
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the gt-df's display:flex !important did override the display:none on small displays
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 2, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Nov 2, 2023
delvh
reviewed
Nov 2, 2023
delvh
approved these changes
Nov 2, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 2, 2023
It seems that the |
add hide-992 helper class to hide element at screens < 992px
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 3, 2023
I've now removed the not needed classes and replaced the css with the helper classes. |
@wxiaoguang is there anything else I should change? |
wxiaoguang
reviewed
Nov 9, 2023
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 15, 2023
wxiaoguang
approved these changes
Nov 16, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 16, 2023
wxiaoguang
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Nov 17, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Nov 17, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 20, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#28120) Decrease issue font size in project template (go-gitea#28054) Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112) add skip ci functionality (go-gitea#28075) Fix project counter in organization/individual profile (go-gitea#28068) Fix Show/hide filetree button on small displays (go-gitea#27881) Change default size of attachments and repo files (go-gitea#28100) Fix Matrix and MSTeams nil dereference (go-gitea#28089)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
the gt-df's display:flex !important did override the display:none on small displays --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the gt-df's display:flex !important did override the display:none on small displays