Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS and PY dependencies #28120

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update JS and PY dependencies #28120

merged 2 commits into from
Nov 20, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 19, 2023 •
edited
Loading

  • Update all JS and PY dependencies minus @mcaptcha/vanilla-glue
  • Adapt to eslint rule rename
  • Regenerate all SVGs because of new optimizations from svgo.
  • Tested mentions, mermaid, vue, api docs

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2023
@silverwind silverwind added type/dependency-update skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 19, 2023
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 19, 2023
@denyskon denyskon added this to the 1.22.0 milestone Nov 19, 2023
@denyskon
Copy link
Member

Backport?

@silverwind
Copy link
Member Author

No real need to backport, so I'd say no

@silverwind silverwind merged commit 06dcb25 into go-gitea:main Nov 20, 2023
24 checks passed
@silverwind silverwind deleted the deps-65 branch November 20, 2023 00:03
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2023
@delvh
Copy link
Member

delvh commented Nov 20, 2023

Why not?

@silverwind
Copy link
Member Author

silverwind commented Nov 20, 2023 •
edited
Loading

Well we can, but at some point we should probably stop backporting stuff that brings no benefit. E.g. the risk of something breaking is there with every dependency update.

@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Nov 20, 2023
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @silverwind, please send one manually. 🍵

go run ./contrib/backport 28120
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 20, 2023
@silverwind silverwind removed backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 20, 2023
@silverwind
Copy link
Member Author

Not gonna bother myself.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 20, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
a44608a 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#28120)
  Decrease issue font size in project template (go-gitea#28054)
  Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112)
  add skip ci functionality (go-gitea#28075)
  Fix project counter in organization/individual profile (go-gitea#28068)
  Fix Show/hide filetree button on small displays (go-gitea#27881)
  Change default size of attachments and repo files (go-gitea#28100)
  Fix Matrix and MSTeams nil dereference (go-gitea#28089)
silverwind added a commit to silverwind/gitea that referenced this pull request Nov 21, 2023
@silverwind
Update JS and PY dependencies (go-gitea#28120)
9493700 
- Update all JS and PY dependencies minus `@mcaptcha/vanilla-glue`
- Adapt to eslint rule rename
- Regenerate all SVGs because of [new
optimizations](https://github.com/svg/svgo/releases/tag/v3.0.4) from
svgo.
- Tested mentions, mermaid, vue, api docs
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@silverwind @fuxiaohei
Update JS and PY dependencies (go-gitea#28120)
a4e5401 
- Update all JS and PY dependencies minus `@mcaptcha/vanilla-glue`
- Adapt to eslint rule rename
- Regenerate all SVGs because of [new
optimizations](https://github.com/svg/svgo/releases/tag/v3.0.4) from
svgo.
- Tested mentions, mermaid, vue, api docs
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @denyskon @delvh @GiteaBot