Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport translations to v1.21 #27899

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Nov 4, 2023

I manually fixed most of the files so that used translation keys don't get deleted.

@GiteaBot GiteaBot added this to the 1.21.0 milestone Nov 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2023
@lunny
Copy link
Member

lunny commented Nov 4, 2023

Have you generated them via build/backport-locale.go ?

@denyskon
Copy link
Member Author

denyskon commented Nov 4, 2023

I first tried, but for some reason the output of that command produced a lot of unnecessary spacing and quotation changes which according to the feedback in previous PRs may break everything, so I ended up doing it manually.

@wxiaoguang
Copy link
Contributor

which according to the feedback in previous PRs may break everything

That's impossible. The generated ini should be able to be loaded correctly.

@denyskon
Copy link
Member Author

denyskon commented Nov 4, 2023

All backticks are replaced by double quotes. If that's okay I can redo it using the script, however I don't see a reason why.

@wxiaoguang
Copy link
Contributor

All backticks are replaced by double quotes. If that's okay I can redo it using the script, however I don't see a reason why.

Crowdin doesn't recognize backticks. key = ` value` then Crowdin treats it as key = "` value`".

The legacy INI package only uses backticks when it is necessary, so key = ` val` will become key = " val" when it saves the INI to a file.

@denyskon
Copy link
Member Author

denyskon commented Nov 4, 2023

Alright, so I now did it using the tool

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2023
@lunny lunny merged commit 4c67c05 into go-gitea:release/v1.21 Nov 4, 2023
26 checks passed
@denyskon denyskon deleted the backport/translations-v1.21 branch November 4, 2023 12:48
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants