Move some JS code from fomantic.js to standalone files
#27994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
delvh
approved these changes
Nov 11, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Nov 12, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
pushed a commit
that referenced
this pull request
Nov 12, 2023
…8001) Backport #27994 by @wxiaoguang To improve maintainability, this PR: 1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic` (the code there are all for aria of fomantic) 2. Move api/transition related code to `web_src/js/modules/fomantic/api.js` and `web_src/js/modules/fomantic/transition.js` No logic is changed. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 13, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix wrong xorm Delete usage (go-gitea#27995) Move some JS code from `fomantic.js` to standalone files (go-gitea#27994) Fix the wrong oauth2 name (go-gitea#27993) Render email addresses as such if followed by punctuation (go-gitea#27987) Show error toast when file size exceeds the limits (go-gitea#27985)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve maintainability, this PR:
web_src/js/modules/ariatoweb_src/js/modules/fomantic(the code there are all for aria of fomantic)web_src/js/modules/fomantic/api.jsandweb_src/js/modules/fomantic/transition.jsNo logic is changed.